From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [patch 1/2] qemu-kvm: use usptream eventfd code
Date: Tue, 07 Sep 2010 11:21:32 +0300
Message-ID: <4C85F60C.3060700@redhat.com>
References: <20100906202015.433641568@amt.cnet> <20100906202301.291967128@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Anthony Liguori <anthony@codemonkey.ws>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:35103 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755327Ab0IGIVh (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 7 Sep 2010 04:21:37 -0400
In-Reply-To: <20100906202301.291967128@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

  On 09/06/2010 11:20 PM, Marcelo Tosatti wrote:
> Upstream code is equivalent.
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>
> Index: qemu-kvm/cpus.c
> ===================================================================
> --- qemu-kvm.orig/cpus.c
> +++ qemu-kvm/cpus.c
> @@ -290,11 +290,6 @@ void qemu_notify_event(void)
>   {
>       CPUState *env = cpu_single_env;
>
> -    if (kvm_enabled()) {
> -        qemu_kvm_notify_work();
> -        return;
> -    }
> -
>       qemu_event_increment ();
>       if (env) {
>           cpu_exit(env);

qemu_event_increment() is indeed equivalent, but what about the rest?  
Are we guaranteed that cpu_single_env == NULL?

-- 
error compiling committee.c: too many arguments to function