From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic Date: Tue, 07 Sep 2010 15:35:27 +0300 Message-ID: <4C86318F.5050101@redhat.com> References: <1283858843-21330-1-git-send-email-joerg.roedel@amd.com> <1283858843-21330-2-git-send-email-joerg.roedel@amd.com> <20100907123016.GA2108@redhat.com> <7BED2EED-8D8B-4D42-9208-D3D04C23C77D@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Daniel P. Berrange" , Joerg Roedel , Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34262 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756658Ab0IGMfg (ORCPT ); Tue, 7 Sep 2010 08:35:36 -0400 In-Reply-To: <7BED2EED-8D8B-4D42-9208-D3D04C23C77D@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 09/07/2010 03:33 PM, Alexander Graf wrote: > >> I agree that its much nicer for mgmt tools if svm/vmx CPU flags can just be >> toggled in the normal manner. Might we also want to have a enable/disable >> nesting flag, so we can mirror the way real hardware lets you disable virt >> in the BIOS even when the CPU(s) have the vmx/svm flags set ? > I don't see how that's useful. We don't model anything like this in the kvm kernel module, so whatever we expose in user space would not be useful for detection testing. Also I'm fairly sure you either want nesting or you don't :). And if you want nesting, you probably want -cpu host too, since you lose migration anyways. Why do you lost migration? -- error compiling committee.c: too many arguments to function