From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic Date: Tue, 07 Sep 2010 16:51:33 +0300 Message-ID: <4C864365.30301@redhat.com> References: <1283858843-21330-1-git-send-email-joerg.roedel@amd.com> <1283858843-21330-2-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Joerg Roedel , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63155 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756036Ab0IGNvq (ORCPT ); Tue, 7 Sep 2010 09:51:46 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 09/07/2010 03:23 PM, Alexander Graf wrote: > > I think we should get rid of kvm_nested and -enable-nesting. Instead, we should enable the SVM bit in the "host" and "qemu64" cpu types, but not in "kvm64". This way users are safe to not use nested svm, but can choose to do so if they like. > > Also, it should be possible to do something like -cpu kvm64,flags=+svm. Without having to mess with -enable-nesting. I agree, -enable-nesting is redundant with -cpu ,+svm. -- error compiling committee.c: too many arguments to function