Re: [patch 1/2] qemu-kvm: use usptream eventfd code

[Avi Kivity <avi@redhat.com>]

  On 09/07/2010 08:25 PM, Marcelo Tosatti wrote:
> On Tue, Sep 07, 2010 at 11:21:32AM +0300, Avi Kivity wrote:
>>   On 09/06/2010 11:20 PM, Marcelo Tosatti wrote:
>>> Upstream code is equivalent.
>>>
>>> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>>>
>>> Index: qemu-kvm/cpus.c
>>> ===================================================================
>>> --- qemu-kvm.orig/cpus.c
>>> +++ qemu-kvm/cpus.c
>>> @@ -290,11 +290,6 @@ void qemu_notify_event(void)
>>>   {
>>>       CPUState *env = cpu_single_env;
>>>
>>> -    if (kvm_enabled()) {
>>> -        qemu_kvm_notify_work();
>>> -        return;
>>> -    }
>>> -
>>>       qemu_event_increment ();
>>>       if (env) {
>>>           cpu_exit(env);
>> qemu_event_increment() is indeed equivalent, but what about the
>> rest?  Are we guaranteed that cpu_single_env == NULL?
> No, its not NULL. But env->current is, so its fine.

Ok, thanks.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.