From: Avi Kivity <avi@redhat.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: Ben-Ami Yassour <benami@il.ibm.com>,
kvm@vger.kernel.org, Amit Shah <amit.shah@redhat.com>,
Yaniv Kamay <ykamay@redhat.com>
Subject: Re: [PATCH] KVM: x86: fixup set_efer()
Date: Wed, 08 Sep 2010 13:04:18 +0300 [thread overview]
Message-ID: <4C875FA2.40004@redhat.com> (raw)
In-Reply-To: <AANLkTinMZiG6iGBv+PHBw_rsn1+SJaPtDA=-zHcU0Mrf@mail.gmail.com>
On 09/04/2010 04:29 PM, Hillf Danton wrote:
> The second call to kvm_mmu_reset_context() seems unnecessary and is
> removed.
>
>
> @@ -783,10 +783,6 @@ static int set_efer(struct kvm_vcpu *vcp
> vcpu->arch.mmu.base_role.nxe = (efer & EFER_NX) && !tdp_enabled;
> kvm_mmu_reset_context(vcpu);
> - /* Update reserved bits */
> - if ((efer ^ old_efer) & EFER_NX)
> - kvm_mmu_reset_context(vcpu);
> -
> return 0;
> }
Hm. As far as I can tell, it's the first call that is unnecessary.
I'll look at the history and try to understand why it was introduced.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next parent reply other threads:[~2010-09-08 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTinMZiG6iGBv+PHBw_rsn1+SJaPtDA=-zHcU0Mrf@mail.gmail.com>
2010-09-08 10:04 ` Avi Kivity [this message]
2010-09-09 8:37 ` [PATCH] KVM: x86: fixup set_efer() Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C875FA2.40004@redhat.com \
--to=avi@redhat.com \
--cc=amit.shah@redhat.com \
--cc=benami@il.ibm.com \
--cc=dhillf@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=ykamay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox