From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM test: tests.cfg.sample: add params to qemu command line properly Date: Fri, 10 Sep 2010 19:04:31 +0300 Message-ID: <4C8A570F.6010909@redhat.com> References: <1284134252-16976-1-git-send-email-lmr@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, kvm@vger.kernel.org, kwolf@redhat.com, lcapitulino@redhat.com To: Lucas Meneghel Rodrigues Return-path: Received: from mx1.redhat.com ([209.132.183.28]:4187 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754362Ab0IJQEg (ORCPT ); Fri, 10 Sep 2010 12:04:36 -0400 In-Reply-To: <1284134252-16976-1-git-send-email-lmr@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/10/2010 06:57 PM, Lucas Meneghel Rodrigues wrote: > There's a small bug on the qemu sample testset for KVM autotest: > We need to append -enable-kvm as extra params to the qemu command > line, not replace all extra params. Small bug, renders the unattended > install unusable for folks trying qemu instead of qemu-kvm. > > > @@ -920,11 +920,15 @@ class Job(DBObject): > WHERE afe_job_id = %s > """ % self.id) > > - t_begin, t_end = time_row[0] > - delta = t_end - t_begin > - minutes, seconds = divmod(delta.seconds, 60) > - hours, minutes = divmod(minutes, 60) > - stats['execution_time'] = "%02d:%02d:%02d" % (hours, minutes, seconds) > + if time_row: > + t_begin, t_end = time_row[0] > + delta = t_end - t_begin > + minutes, seconds = divmod(delta.seconds, 60) > + hours, minutes = divmod(minutes, 60) > + stats['execution_time'] = "%02d:%02d:%02d" % (hours, minutes, > + seconds) > + else: > + stats['execution_time'] = "00:00:00" Appears to be unrelated. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.