From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features Date: Sun, 12 Sep 2010 08:05:55 +0200 Message-ID: <4C8C6DC3.9030009@redhat.com> References: <1284133120-19453-1-git-send-email-joerg.roedel@amd.com> <1284133120-19453-3-git-send-email-joerg.roedel@amd.com> <20100911142018.GA680@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Graf , Joerg Roedel , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Joerg Roedel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42563 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397Ab0ILGGJ (ORCPT ); Sun, 12 Sep 2010 02:06:09 -0400 In-Reply-To: <20100911142018.GA680@8bytes.org> Sender: kvm-owner@vger.kernel.org List-ID: On 09/11/2010 05:20 PM, Joerg Roedel wrote: > On Sat, Sep 11, 2010 at 03:43:02PM +0200, Alexander Graf wrote: >>> @@ -305,6 +322,8 @@ static x86_def_t builtin_x86_defs[] = { >>> CPUID_EXT3_OSVW, CPUID_EXT3_IBS */ >>> .ext3_features = CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM | >>> CPUID_EXT3_ABM | CPUID_EXT3_SSE4A, >>> + .svm_features = CPUID_SVM_NPT | CPUID_SVM_LBRV | CPUID_SVM_NRIPSAVE | >>> + CPUID_SVM_VMCBCLEAN, >> Does that phenom already do all those? It does NPT, but I'm not sure >> about NRIPSAVE for example. > Depends on which Phenom you have. A Phenom II has NRIPSAVE but the old > Phenoms don't have it. For the SVM features it is not that important > what the host hardware supports but what KVM can emulate. VMCBCLEAN can > be emulated without supporting it in the host for example. Well, let's have a phenom2 type for those new features (and any other features the phenom 2 has). What's the point of using the name of existing hardware if it doesn't match that hardware? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.