From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 18/24] Exiting from L2 to L1 Date: Mon, 13 Sep 2010 11:34:07 +0200 Message-ID: <4C8DF00F.5020904@redhat.com> References: <1276431753-nyh@il.ibm.com> <20100912170503.GA7828@fermat.math.technion.ac.il> <4C8D0C19.4050003@redhat.com> <201009131353.56814.sheng@linux.intel.com> <4C8DE630.9010405@redhat.com> <20100913090144.GA17418@fermat.math.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Sheng Yang , kvm@vger.kernel.org To: "Nadav Har'El" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:3715 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751018Ab0IMJeQ (ORCPT ); Mon, 13 Sep 2010 05:34:16 -0400 In-Reply-To: <20100913090144.GA17418@fermat.math.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 09/13/2010 11:01 AM, Nadav Har'El wrote: > >> 3. if (exit_reason& FAILED_ENTRY) vmcs12->vm_entry_intr_info_field = >> vmcs_read32(VM_ENTRY_INTR_INFO_FIELD); > I think you meant the opposite condition? > > if (!(exit_reason& FAILED_ENTRY)) vmcs12->vm_entry_intr_info_field = > vmcs_read32(VM_ENTRY_INTR_INFO_FIELD); > Dunno, I think both are subtly broken. -- error compiling committee.c: too many arguments to function