From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH] Rename KVM_UPSTREAM to OBSOLETE_KVM_IMPL
Date: Mon, 13 Sep 2010 21:03:19 +0200
Message-ID: <4C8E7577.3020708@web.de>
References: <1284400455-29591-1-git-send-email-avi@redhat.com> <4C8E72E8.1090706@web.de> <4C8E73F0.6030302@codemonkey.ws>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig74AB280B1CF2A0B6864743F4"
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org,
	Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fmmailgate01.web.de ([217.72.192.221]:46739 "EHLO
	fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754869Ab0IMTDZ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 13 Sep 2010 15:03:25 -0400
In-Reply-To: <4C8E73F0.6030302@codemonkey.ws>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig74AB280B1CF2A0B6864743F4
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Am 13.09.2010 20:56, Anthony Liguori wrote:
> On 09/13/2010 01:52 PM, Jan Kiszka wrote:
>> Am 13.09.2010 19:54, Avi Kivity wrote:
>>  =20
>>> The symbol KVM_UPSTREAM is used to mark sections of code that are
>>> part of
>>> the upstream kvm implemetation that is not used in qemu-kvm.  However=

>>> the
>>> name becomes ambiguous if qemu-kvm is merged upstream.
>>>     =20
>> I doubt this is describing all cases correctly as well. Some changes
>> should rather happen the other way around (e.g. you surely don't want =
to
>> obsolete x86 kvm_arch_put/get_registers in favor of
>> kvm_arch_load/save_regs, do you?).
>>   =20
>=20
> There's really no perfect name to describe what we're actually doing
> here.  It's probably not a detail worth worrying that much about.

I don't mind the name as long as it doesn't reflect the strategy (but
why this change at all then?).

Jan (who would prefer to have the time for doing the cleanups)


--------------enig74AB280B1CF2A0B6864743F4
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAkyOdXcACgkQitSsb3rl5xRw6QCdFoNAEzm3Nj9aSCK7ZVY9ncMw
SBYAoOQahTCNEnEDSGRmS66qb+rqQ7sJ
=3m94
-----END PGP SIGNATURE-----

--------------enig74AB280B1CF2A0B6864743F4--