From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Rename KVM_UPSTREAM to OBSOLETE_KVM_IMPL Date: Tue, 14 Sep 2010 11:29:10 +0200 Message-ID: <4C8F4066.3020505@redhat.com> References: <1284400455-29591-1-git-send-email-avi@redhat.com> <4C8E72E8.1090706@web.de> <4C8E73F0.6030302@codemonkey.ws> <4C8E7577.3020708@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , kvm@vger.kernel.org, Marcelo Tosatti To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28737 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332Ab0INJ3Q (ORCPT ); Tue, 14 Sep 2010 05:29:16 -0400 In-Reply-To: <4C8E7577.3020708@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 09/13/2010 09:03 PM, Jan Kiszka wrote: > Am 13.09.2010 20:56, Anthony Liguori wrote: >> On 09/13/2010 01:52 PM, Jan Kiszka wrote: >>> Am 13.09.2010 19:54, Avi Kivity wrote: >>> >>>> The symbol KVM_UPSTREAM is used to mark sections of code that are >>>> part of >>>> the upstream kvm implemetation that is not used in qemu-kvm. However >>>> the >>>> name becomes ambiguous if qemu-kvm is merged upstream. >>>> >>> I doubt this is describing all cases correctly as well. Some changes >>> should rather happen the other way around (e.g. you surely don't want to >>> obsolete x86 kvm_arch_put/get_registers in favor of >>> kvm_arch_load/save_regs, do you?). >>> >> There's really no perfect name to describe what we're actually doing >> here. It's probably not a detail worth worrying that much about. > I don't mind the name as long as it doesn't reflect the strategy (but > why this change at all then?). It would be silly to have a define KVM_UPSTREAM in upstream. > Jan (who would prefer to have the time for doing the cleanups) > Hopefully, with a single source base doing the cleanups would be easier, so a more efficient use of the time we have. -- error compiling committee.c: too many arguments to function