From: Kevin Wolf <kwolf@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Chris Wright <chrisw@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] Re: KVM call minutes for Sept 14
Date: Wed, 15 Sep 2010 15:30:02 +0200 [thread overview]
Message-ID: <4C90CA5A.1040200@redhat.com> (raw)
In-Reply-To: <4C90C855.5010306@codemonkey.ws>
Am 15.09.2010 15:21, schrieb Anthony Liguori:
> On 09/15/2010 07:38 AM, Kevin Wolf wrote:
>> No, we don't really care if the L2 entry is on disk. If the guest want
>> to have its data safe it needs to issue an explicit flush anyway. The
>> only thing we want to achieve with bdrv_write_sync is to maintain the
>> right order between metadata updates to survive a crash without corruption.
>>
>
> Ah, yes, this is brand new :-)
>
> I was looking at my QED branch which is a few weeks old.
Well, the whole bdrv_pwrite_sync thing is new - with your benchmarking
you probably caught qcow2 at its worst performance in years. Initially I
just blindly converted everything to be on the safe side, and now we
need to optimize to get the performance back. There are probably some
more syncs that can be removed in less common paths.
Kevin
next prev parent reply other threads:[~2010-09-15 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 14:47 KVM call minutes for Sept 14 Chris Wright
2010-09-14 15:11 ` Anthony Liguori
2010-09-15 8:30 ` [Qemu-devel] " Kevin Wolf
2010-09-15 12:26 ` Anthony Liguori
2010-09-15 12:38 ` Kevin Wolf
2010-09-15 13:21 ` Anthony Liguori
2010-09-15 13:30 ` Kevin Wolf [this message]
2010-09-15 13:52 ` Anthony Liguori
2010-09-15 13:57 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C90CA5A.1040200@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=chrisw@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox