From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: PATCH: virtio_console: Fix poll blocking even though there is data to read Date: Wed, 15 Sep 2010 15:37:21 +0200 Message-ID: <4C90CC11.70202@redhat.com> References: <4C90C475.4010809@redhat.com> <20100915132536.GA12320@amit-laptop.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Cc: spice-devel@lists.freedesktop.org, rusty@rustcorp.com.au, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org To: Amit Shah Return-path: In-Reply-To: <20100915132536.GA12320@amit-laptop.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spice-devel-bounces+gcesd-spice-space-devel=m.gmane.org@lists.freedesktop.org Errors-To: spice-devel-bounces+gcesd-spice-space-devel=m.gmane.org@lists.freedesktop.org List-Id: kvm.vger.kernel.org SGksCgpPbiAwOS8xNS8yMDEwIDAzOjI1IFBNLCBBbWl0IFNoYWggd3JvdGU6Cj4gT24gKFdlZCkg U2VwIDE1IDIwMTAgWzE1OjA0OjUzXSwgSGFucyBkZSBHb2VkZSB3cm90ZToKPj4gSGkgQWxsLAo+ Pgo+PiBJIGZvdW5kIHRoaXMgd2hpbGUgd29ya2luZyBvbiBhIExpbnV4IGFnZW50IGZvciBzcGlj ZSwgdGhlIHN5bXB0b20gSSB3YXMKPj4gc2VlaW5nIHdhcyBzZWxlY3QgYmxvY2tpbmcgb24gdGhl IHNwaWNlIHZkYWdlbnQgdmlydGlvIHNlcmlhbCBwb3J0IGV2ZW4KPj4gdGhvdWdoIHRoZXJlIHdl cmUgbWVzc2FnZXMgcXVldWVkIHVwIHRoZXJlLgo+Pgo+PiBJIGZvdW5kIHRoaXMgd2hpbGUgd29y a2luZyBvbiBhIExpbnV4IGFnZW50IGZvciBzcGljZSwgdGhlIHN5bXB0b20gSSB3YXMKPj4gc2Vl aW5nIHdhcyBzZWxlY3QgYmxvY2tpbmcgb24gdGhlIHNwaWNlIHZkYWdlbnQgdmlydGlvIHNlcmlh bCBwb3J0IGV2ZW4KPj4gdGhvdWdoIHRoZXJlIHdlcmUgbWVzc2FnZXMgcXVldWVkIHVwIHRoZXJl Lgo+Pgo+PiB2aXJ0aW9fY29uc29sZSdzIHBvcnRfZm9wc19wb2xsIGNoZWNrcyBwb3J0LT5pbmJ1 ZiAhPSBOVUxMIHRvIGRldGVybWluZSBpZgo+PiByZWFkIHdvbid0IGJsb2NrLiBIb3dldmVyIGlm IGFuIGFwcGxpY2F0aW9uIHJlYWRzIGVub3VnaCBieXRlcyBmcm9tIGluYnVmCj4+IHRocm91Z2gg cG9ydF9mb3BzX3JlYWQsIHRvIGVtcHR5IHRoZSBjdXJyZW50IHBvcnQtPmluYnVmLCBwb3J0LT5p bmJ1Zgo+PiB3aWxsIGJlIE5VTEwgZXZlbiB0aG91Z2ggdGhlcmUgbWF5IGJlIGJ1ZmZlcnMgbGVm dCBpbiB0aGUgdmlydHF1ZXVlLgo+Pgo+PiBUaGlzIGNhdXNlcyBwb2xsKCkgdG8gYmxvY2sgZXZl biB0aG91Z2ggdGhlcmUgaXMgZGF0YSB0byBiZSByZWFkLCB0aGlzIHBhdGNoCj4+IGZpeGVzIHRo aXMgYnkgdXNpbmcgdGhlIGFscmVkeSBkZWZpbmVkIHdpbGxfcmVhZF9ibG9jayB1dGlsaXR5IGZ1 bmN0aW9uCj4+IGluc3RlYWQgb2YgdGhlIHBvcnQtPmluYnVmICE9IE5VTEwgY2hlY2suCj4+Cj4+ IFNpZ25lZC1vZmYtQnk6IEhhbnMgZGUgR29lZGU8aGRlZ29lZGVAcmVkaGF0LmNvbT4KPj4KPj4g UmVnYXJkcywKPj4KPj4gSGFucwo+Cj4+IGRpZmYgLXVwIGxpbnV4LTIuNi4zNS54ODZfNjQvZHJp dmVycy9jaGFyL3ZpcnRpb19jb25zb2xlLmN+IGxpbnV4LTIuNi4zNS54ODZfNjQvZHJpdmVycy9j aGFyL3ZpcnRpb19jb25zb2xlLmMKPj4gLS0tIGxpbnV4LTIuNi4zNS54ODZfNjQvZHJpdmVycy9j aGFyL3ZpcnRpb19jb25zb2xlLmN+CTIwMTAtMDgtMDIgMDA6MTE6MTQuMDAwMDAwMDAwICswMjAw Cj4+ICsrKyBsaW51eC0yLjYuMzUueDg2XzY0L2RyaXZlcnMvY2hhci92aXJ0aW9fY29uc29sZS5j CTIwMTAtMDktMTUgMTM6Mzk6MjkuMDQzNTA1MDAwICswMjAwCj4+IEBAIC02NDIsNyArNjQyLDcg QEAgc3RhdGljIHVuc2lnbmVkIGludCBwb3J0X2ZvcHNfcG9sbChzdHJ1Ywo+PiAgIAlwb2xsX3dh aXQoZmlscCwmcG9ydC0+d2FpdHF1ZXVlLCB3YWl0KTsKPj4KPj4gICAJcmV0ID0gMDsKPj4gLQlp ZiAocG9ydC0+aW5idWYpCj4+ICsJaWYgKCF3aWxsX3JlYWRfYmxvY2socG9ydCkpCj4KPiBMb29r cyBjb3JyZWN0LCBidXQgdGhpcyBzaG91bGQgYmUKPgo+IAlpZiAocG9ydF9oYXNfZGF0YShwb3J0 KSkKPgo+IGluc3RlYWQuCgpUaGF0IGNlcnRhaW5seSB3b3JrcyBmb3IgbWUgKGFzIGluIHdpbGwg c3RpbGwgZml4IHRoZSBidWcgSSdtIGhpdHRpbmcpLCBidXQKcXVvdGluZyBmcm9tICJtYW4gMiBz ZWxlY3QiOgoKICAgICAgICBUaHJlZSAgaW5kZXBlbmRlbnQgIHNldHMgb2YgZmlsZSBkZXNjcmlw dG9ycyBhcmUgd2F0Y2hlZC4gIFRob3NlIGxpc3RlZAogICAgICAgIGluIHJlYWRmZHMgd2lsbCBi ZSB3YXRjaGVkIHRvIHNlZSBpZiBjaGFyYWN0ZXJzICBiZWNvbWUgIGF2YWlsYWJsZSAgZm9yCiAg ICAgICAgcmVhZGluZyAgKG1vcmUgIHByZWNpc2VseSwgdG8gc2VlIGlmIGEgcmVhZCB3aWxsIG5v dCBibG9jazsgaW4gcGFydGljdeKAkAogICAgICAgIGxhciwgYSBmaWxlIGRlc2NyaXB0b3IgaXMg YWxzbyByZWFkeSBvbiBlbmQtb2YtZmlsZSkKCk5vdGljZSB0aGUgImEgZmlsZSBkZXNjcmlwdG9y IGlzIGFsc28gcmVhZHkgb24gZW5kLW9mLWZpbGUiLCBhbmQKcG9ydF9mb3BzX3JlYWQgdHJlYXRz IHRoZSBob3N0IG5vdCBiZWluZyBjb25uZWN0ZWQgYXMgZW9mIChpdCByZXR1cm5zIDAKaW4gdGhh dCBjYXNlKS4gU28gZnJvbSBhbiBBUEkgcG92IEknbSBub3Qgc3VyZSB3aGF0IGlzIGNvcnJlY3Qu CgpSZWdhcmRzLAoKSGFucwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpTcGljZS1kZXZlbCBtYWlsaW5nIGxpc3QKU3BpY2UtZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9z cGljZS1kZXZlbAo=