From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: PATCH: virtio_console: Fix poll blocking even though there is data to read Date: Wed, 15 Sep 2010 16:02:40 +0200 Message-ID: <4C90D200.4070507@redhat.com> References: <4C90C475.4010809@redhat.com> <20100915132536.GA12320@amit-laptop.redhat.com> <4C90CC11.70202@redhat.com> <20100915134624.GB12320@amit-laptop.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Cc: spice-devel@lists.freedesktop.org, rusty@rustcorp.com.au, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org To: Amit Shah Return-path: In-Reply-To: <20100915134624.GB12320@amit-laptop.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spice-devel-bounces+gcesd-spice-space-devel=m.gmane.org@lists.freedesktop.org Errors-To: spice-devel-bounces+gcesd-spice-space-devel=m.gmane.org@lists.freedesktop.org List-Id: kvm.vger.kernel.org SGksCgpPbiAwOS8xNS8yMDEwIDAzOjQ2IFBNLCBBbWl0IFNoYWggd3JvdGU6Cj4gT24gKFdlZCkg U2VwIDE1IDIwMTAgWzE1OjM3OjIxXSwgSGFucyBkZSBHb2VkZSB3cm90ZToKPj4+PiAtLS0gbGlu dXgtMi42LjM1Lng4Nl82NC9kcml2ZXJzL2NoYXIvdmlydGlvX2NvbnNvbGUuY34JMjAxMC0wOC0w MiAwMDoxMToxNC4wMDAwMDAwMDAgKzAyMDAKPj4+PiArKysgbGludXgtMi42LjM1Lng4Nl82NC9k cml2ZXJzL2NoYXIvdmlydGlvX2NvbnNvbGUuYwkyMDEwLTA5LTE1IDEzOjM5OjI5LjA0MzUwNTAw MCArMDIwMAo+Pj4+IEBAIC02NDIsNyArNjQyLDcgQEAgc3RhdGljIHVuc2lnbmVkIGludCBwb3J0 X2ZvcHNfcG9sbChzdHJ1Ywo+Pj4+ICAgCXBvbGxfd2FpdChmaWxwLCZwb3J0LT53YWl0cXVldWUs IHdhaXQpOwo+Pj4+Cj4+Pj4gICAJcmV0ID0gMDsKPj4+PiAtCWlmIChwb3J0LT5pbmJ1ZikKPj4+ PiArCWlmICghd2lsbF9yZWFkX2Jsb2NrKHBvcnQpKQo+Pj4KPj4+IExvb2tzIGNvcnJlY3QsIGJ1 dCB0aGlzIHNob3VsZCBiZQo+Pj4KPj4+IAlpZiAocG9ydF9oYXNfZGF0YShwb3J0KSkKPj4+Cj4+ PiBpbnN0ZWFkLgo+Pgo+PiBUaGF0IGNlcnRhaW5seSB3b3JrcyBmb3IgbWUgKGFzIGluIHdpbGwg c3RpbGwgZml4IHRoZSBidWcgSSdtIGhpdHRpbmcpLCBidXQKPj4gcXVvdGluZyBmcm9tICJtYW4g MiBzZWxlY3QiOgo+Pgo+PiAgICAgICAgIFRocmVlICBpbmRlcGVuZGVudCAgc2V0cyBvZiBmaWxl IGRlc2NyaXB0b3JzIGFyZSB3YXRjaGVkLiAgVGhvc2UgbGlzdGVkCj4+ICAgICAgICAgaW4gcmVh ZGZkcyB3aWxsIGJlIHdhdGNoZWQgdG8gc2VlIGlmIGNoYXJhY3RlcnMgIGJlY29tZSAgYXZhaWxh YmxlICBmb3IKPj4gICAgICAgICByZWFkaW5nICAobW9yZSAgcHJlY2lzZWx5LCB0byBzZWUgaWYg YSByZWFkIHdpbGwgbm90IGJsb2NrOyBpbiBwYXJ0aWN14oCQCj4+ICAgICAgICAgbGFyLCBhIGZp bGUgZGVzY3JpcHRvciBpcyBhbHNvIHJlYWR5IG9uIGVuZC1vZi1maWxlKQo+Pgo+PiBOb3RpY2Ug dGhlICJhIGZpbGUgZGVzY3JpcHRvciBpcyBhbHNvIHJlYWR5IG9uIGVuZC1vZi1maWxlIiwgYW5k Cj4+IHBvcnRfZm9wc19yZWFkIHRyZWF0cyB0aGUgaG9zdCBub3QgYmVpbmcgY29ubmVjdGVkIGFz IGVvZiAoaXQgcmV0dXJucyAwCj4+IGluIHRoYXQgY2FzZSkuIFNvIGZyb20gYW4gQVBJIHBvdiBJ J20gbm90IHN1cmUgd2hhdCBpcyBjb3JyZWN0Lgo+Cj4gcG9sbCgyKSBzYXlzOgo+Cj4gICAgICAg ICAgICAgICAgUE9MTElOIFRoZXJlIGlzIGRhdGEgdG8gcmVhZC4KPgo+IFRoYXQgbWFrZXMgaXQg c2ltcGxlLgo+Cj4gQWxzbywgd2UgYWxzbyBzZXQgUE9MTEhVUCBpbiBjYXNlIHRoZSBob3N0IGlz IGRpc2Nvbm5lY3RlZCwgc28gaWYgaG9zdAo+IGlzIG5vdCBjb25uZWN0ZWQgd2hpbGUgdGhlcmUn cyBkYXRhIHRvIHJlYWQsIHdlJ2xsIGdldCBQT0xMSU58UE9MTEhVUCBpbgo+IHJldmVudHMsIGFu ZCBmdXJ0aGVyIHJlYWRzIHdpbGwgYmUgYmxvY2tlZC4KPgoKQWgsIEkgY29tcGxldGVseSBtaXNz ZWQgdGhlIFBPTExIVVAgZ2V0dGluZyBzZXQgdGhpbmdpZS4gSSBndWVzcyB0aGF0IHdpbGwKZ2V0 IHVzZWQgYnkgdGhlIGtlcm5lbCB0byBhbHNvIG5vdCBibG9jayBpZiBhbnkgZmRzIGhhdmUgaXQg c2FpZCBpbiBzZWxlY3QncwpyZWFkZmRzIGFyZ3VtZW50LgoKT25lIG5ldyBwYXRjaCBjb21pbmcg dXAhCgpSZWdhcmRzLAoKSGFucwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpTcGljZS1kZXZlbCBtYWlsaW5nIGxpc3QKU3BpY2UtZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9zcGljZS1kZXZlbAo=