From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v4 0/6] Nonatomic interrupt injection
Date: Thu, 16 Sep 2010 15:35:19 +0200
Message-ID: <4C921D17.3010603@redhat.com>
References: <1283168222-2242-1-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
To: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:60427 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754257Ab0IPNfX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 16 Sep 2010 09:35:23 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8GDZNjq026417
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Thu, 16 Sep 2010 09:35:23 -0400
In-Reply-To: <1283168222-2242-1-git-send-email-avi@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

  On 08/30/2010 02:36 PM, Avi Kivity wrote:
> This patchset changes interrupt injection to be done from normal process
> context instead of interrupts disabled context.  This is useful for real
> mode interrupt injection on Intel without the current hacks (injecting as
> a software interrupt of a vm86 task), reducing latencies, and later, for
> allowing nested virtualization code to use kvm_read_guest()/kvm_write_guest()
> instead of kmap() to access the guest vmcb/vmcs.
>
> Seems to survive a hack that cancels every 16th entry, after injection has
> already taken place.
>
> With the PIC reset fix posted earlier, this passes autotest on both AMD and
> Intel, with in-kernel irqchip.  I'll run -no-kvm-irqchip tests shortly.
>
> Please review carefully, esp. the first patch.  Any missing kvm_make_request()
> there may result in a hung guest.
>

This is now merged, with the change pointed out by Marcelo.  Windows XP 
x64 fails installation without

(vmx.c handle_cr())
          case 8: {
                  u8 cr8_prev = kvm_get_cr8(vcpu);
                  u8 cr8 = kvm_register_read(vcpu, reg);
                  kvm_set_cr8(vcpu, cr8);
                  skip_emulated_instruction(vcpu);
                  if (irqchip_in_kernel(vcpu->kvm))
                      return 1;
-                if (cr8_prev <= cr8)
-                    return 1;
                  vcpu->run->exit_reason = KVM_EXIT_SET_TPR;
                  return 0;
              }

Which doesn't make any sense (anyone?).  The failure is present even 
without the patchset, and is fixed by the same hack, so a regression was 
not introduced.

-- 
error compiling committee.c: too many arguments to function