public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Kohl <bernhard.kohl@nsn.com>
To: ext Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, Thomas Ostler <thomas.ostler@nsn.com>
Subject: Re: [PATCH] device-assignment: register a reset function
Date: Fri, 17 Sep 2010 16:14:50 +0200	[thread overview]
Message-ID: <4C9377DA.9050904@nsn.com> (raw)
In-Reply-To: <AANLkTi=PRw6iztyuSVw6XMQbRFiE=6b7-UN8Z1zfinaP@mail.gmail.com>

Am 16.09.2010 17:48, schrieb ext Alex Williamson:
>> +static void reset_assigned_device(void *opaque)
>> >  +{
>> >  +    PCIDevice *d = (PCIDevice *)opaque;
>> >  +    uint32_t conf;
>> >  +
>> >  +    /* reset the bus master bit to avoid further DMA transfers */
>> >  +    conf = assigned_dev_pci_read_config(d, 0x04, 0x02);
>> >  +    conf&= ~0x04;
>> >  +    assigned_dev_pci_write_config(d, 0x04, conf, 0x02);
>>      
> This should use defined macros, PCI_COMMAND&  PCI_COMMAND_MASTER.
> Otherwise seems ok.  Thanks,
>
> Alex
>    

Thanks for the review. Will be fixed in v2.

Bernhard

  reply	other threads:[~2010-09-17 14:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-14 15:04 [PATCH] device-assignment: register a reset function Bernhard Kohl
2010-09-16 15:48 ` Alex Williamson
2010-09-17 14:14   ` Bernhard Kohl [this message]
2010-09-17 15:27     ` Bernhard Kohl
2010-09-17 16:16       ` Alex Williamson
2010-09-21 14:01         ` Bernhard Kohl
     [not found]         ` <1289820837-24254-1-git-send-email-bernhard.kohl@nsn.com>
2010-11-15 12:08           ` Jan Kiszka
2010-11-15 20:38             ` Alex Williamson
2010-11-15 21:58               ` Jan Kiszka
2010-11-16 11:39                 ` Bernhard Kohl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9377DA.9050904@nsn.com \
    --to=bernhard.kohl@nsn.com \
    --cc=alex.williamson@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=thomas.ostler@nsn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox