From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Kohl <bernhard.kohl@nsn.com>
Subject: Re: [PATCH] device-assignment: register a reset function
Date: Fri, 17 Sep 2010 16:14:50 +0200
Message-ID: <4C9377DA.9050904@nsn.com>
References: <1284476671-21012-1-git-send-email-bernhard.kohl@nsn.com> <AANLkTi=PRw6iztyuSVw6XMQbRFiE=6b7-UN8Z1zfinaP@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Thomas Ostler <thomas.ostler@nsn.com>
To: ext Alex Williamson <alex.williamson@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from demumfd002.nsn-inter.net ([93.183.12.31]:13425 "EHLO
	demumfd002.nsn-inter.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753651Ab0IQOPJ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 17 Sep 2010 10:15:09 -0400
In-Reply-To: <AANLkTi=PRw6iztyuSVw6XMQbRFiE=6b7-UN8Z1zfinaP@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 16.09.2010 17:48, schrieb ext Alex Williamson:
>> +static void reset_assigned_device(void *opaque)
>> >  +{
>> >  +    PCIDevice *d = (PCIDevice *)opaque;
>> >  +    uint32_t conf;
>> >  +
>> >  +    /* reset the bus master bit to avoid further DMA transfers */
>> >  +    conf = assigned_dev_pci_read_config(d, 0x04, 0x02);
>> >  +    conf&= ~0x04;
>> >  +    assigned_dev_pci_write_config(d, 0x04, conf, 0x02);
>>      
> This should use defined macros, PCI_COMMAND&  PCI_COMMAND_MASTER.
> Otherwise seems ok.  Thanks,
>
> Alex
>    

Thanks for the review. Will be fixed in v2.

Bernhard