From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH v4 0/6] Nonatomic interrupt injection
Date: Sun, 19 Sep 2010 12:09:32 +0200 [thread overview]
Message-ID: <4C95E15C.7030103@redhat.com> (raw)
In-Reply-To: <4C95D7B2.7010903@redhat.com>
On 09/19/2010 11:28 AM, Avi Kivity wrote:
> On 09/19/2010 11:25 AM, Avi Kivity wrote:
>>
>> Let's assume that this is so (I'll check).
>
> It's trivially so. If a completion causes an interrupt to be raised,
> the vcpu's apic code is executed in the iothread context.
>
>
However, that's a bug even with the optimization removed:
iothread vcpu
ioapic interrrupt
apic: set isr
mov $large_value, cr8
on_vcpu(inject)
inject interrupt even though cr8 inhibits it
Setting the isr and injecting the interrupt should be an atomic
operation (easily done be running the apic code on the vcpu thread).
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-09-19 10:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 11:36 [PATCH v4 0/6] Nonatomic interrupt injection Avi Kivity
2010-08-30 11:36 ` [PATCH v4 1/6] KVM: Check for pending events before attempting injection Avi Kivity
2010-08-30 17:41 ` Marcelo Tosatti
2010-08-30 11:36 ` [PATCH v4 2/6] KVM: VMX: Split up vmx_complete_interrupts() Avi Kivity
2010-08-30 11:36 ` [PATCH v4 3/6] KVM: VMX: Move real-mode interrupt injection fixup to vmx_complete_interrupts() Avi Kivity
2010-08-30 11:37 ` [PATCH v4 4/6] KVM: VMX: Parameterize vmx_complete_interrupts() for both exit and entry Avi Kivity
2010-08-30 11:37 ` [PATCH v4 5/6] KVM: Non-atomic interrupt injection Avi Kivity
2010-08-30 11:37 ` [PATCH v4 6/6] KVM: VMX: Move fixup_rmode_irq() to avoid forward declaration Avi Kivity
2010-08-30 11:52 ` [PATCH v4 0/6] Nonatomic interrupt injection Avi Kivity
2010-09-16 13:35 ` Avi Kivity
2010-09-17 19:12 ` Marcelo Tosatti
2010-09-19 9:25 ` Avi Kivity
2010-09-19 9:28 ` Avi Kivity
2010-09-19 10:09 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C95E15C.7030103@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox