From: Avi Kivity <avi@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Ingo Molnar <mingo@elte.hu>
Subject: raw_spinlock_t rules
Date: Sun, 19 Sep 2010 15:09:12 +0200 [thread overview]
Message-ID: <4C960B78.4010804@redhat.com> (raw)
Some time ago, the i8259 emulation code in kvm was changed to use
raw_spinlock_t, as it was called in a preempt_disable() and
local_irq_disable() context, which doesn't work with preemptible
spinlocks used with CONFIG_PREEMPT_RT.
In Linux 2.6.37, the spinlock will no longer be taken in these contexts,
so I'd like to change it to a normal spinlock_t. However, it is still
taken in a spin_lock_irq() context.
Is it okay to do this change? I figured since spin_lock_irq() is part
of the spinlock infrastructure it might to the right thing.
--
error compiling committee.c: too many arguments to function
next reply other threads:[~2010-09-19 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 13:09 Avi Kivity [this message]
2010-09-19 16:38 ` raw_spinlock_t rules Steven Rostedt
2010-09-19 16:43 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C960B78.4010804@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox