From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/9] msix: move definitions from msix.c to msix.h Date: Tue, 21 Sep 2010 18:03:02 +0200 Message-ID: <4C98D736.1060203@redhat.com> References: <1284995210-32432-1-git-send-email-avi@redhat.com> <1284995210-32432-5-git-send-email-avi@redhat.com> <20100920165624.GC29862@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7079 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753928Ab0IUQDG (ORCPT ); Tue, 21 Sep 2010 12:03:06 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8LG35DH014552 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Sep 2010 12:03:05 -0400 In-Reply-To: <20100920165624.GC29862@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/20/2010 06:56 PM, Michael S. Tsirkin wrote: > On Mon, Sep 20, 2010 at 05:06:45PM +0200, Avi Kivity wrote: > > This allows us to reuse them from the kvm support code. > > > > Signed-off-by: Avi Kivity > > I would rather all dealings with MSI-X table stayed in one place. All we > need is just the entry, so let's add APIs to retrieve MSIX address and > data: > > uint64_t msix_get_address(dev, vector) > uint32_t msix_get_data(dev, vector) > > and that will be enough for KVM. > Ok, will do. -- error compiling committee.c: too many arguments to function