From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 8/9] Protect qemu-kvm.h declarations with NEED_CPU_H Date: Tue, 21 Sep 2010 18:03:55 +0200 Message-ID: <4C98D76B.6050403@redhat.com> References: <1284995210-32432-1-git-send-email-avi@redhat.com> <1284995210-32432-9-git-send-email-avi@redhat.com> <20100920170500.GE29862@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11138 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755488Ab0IUQEA (ORCPT ); Tue, 21 Sep 2010 12:04:00 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8LG3xIb021878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Sep 2010 12:03:59 -0400 In-Reply-To: <20100920170500.GE29862@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/20/2010 07:05 PM, Michael S. Tsirkin wrote: > On Mon, Sep 20, 2010 at 05:06:49PM +0200, Avi Kivity wrote: > > Target-specific definitions need to be qualified with NEED_CPU_H so kvm.h > > can be included from non-target-specific files. > > > > Signed-off-by: Avi Kivity > > Long term, would be cleaner to split this into two files ... Yes, this is a pain to deal with. > > --- > > kvm-stub.c | 1 + > > qemu-kvm.h | 21 ++++++++++++++++++++- > > 2 files changed, 21 insertions(+), 1 deletions(-) > > > > diff --git a/kvm-stub.c b/kvm-stub.c > > index 37d2b7a..2e4bf00 100644 > > --- a/kvm-stub.c > > +++ b/kvm-stub.c > > @@ -169,3 +169,4 @@ bool kvm_msix_notify(PCIDevice *dev, unsigned vector) > > { > > return false; > > } > > + > > intentional? Nope. -- error compiling committee.c: too many arguments to function