From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/9] msix/kvm integration cleanups Date: Tue, 21 Sep 2010 18:05:10 +0200 Message-ID: <4C98D7B6.2010908@redhat.com> References: <1284995210-32432-1-git-send-email-avi@redhat.com> <20100920170247.GD29862@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56059 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755512Ab0IUQFP (ORCPT ); Tue, 21 Sep 2010 12:05:15 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8LG5EXM031582 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Sep 2010 12:05:14 -0400 In-Reply-To: <20100920170247.GD29862@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/20/2010 07:02 PM, Michael S. Tsirkin wrote: > On Mon, Sep 20, 2010 at 05:06:41PM +0200, Avi Kivity wrote: > > This cleans up msix/kvm integration a bit. The really important patch is the > > last one, which allows msix.o to be part of non-target-specific build. > > I actually thoought this later move should be done in a different way: > - add all functions msix uses to kvm-stub.c Isn't that what I did? > - kvm_irq_routing_entry should also have a stub > > I sent some minor comments in case you have a reason > to prefer this way. My motivation is really the last patch. If you explain what you'd like to see I'll try to do it. -- error compiling committee.c: too many arguments to function