Re: [PATCH 2/4] KVM: MMU: support unsync sp out of the protection of 'mmu_lock'

Avi Kivity
2010-09-26T13:02:35Z

On 09/23/2010 05:05 AM, Xiao Guangrong wrote:
> >
> > How can you drop an active unsync page?
> >
> > I'm missing something here.
> >
>
> Umm, this feature is used like this:
>
> hold mmu_lock
> increase sp->active_count
> release mmu_lock
> ......
> hold mmu_lock
> increase sp->active_count
> if (!sp->active_count&& sp->invalid)
> kvm_mmu_free_page(sp);
> ......
> release mmu_lock
>
>

Well, the implementation is confusing. Maybe we should have
mmu_ref_sp() and mmu_drop_sp() wrappers to manage the reference counts
and call mmu_free_page() automatically.

--
error compiling committee.c: too many arguments to function