* inconsistent use of $TMP vs. $TMPDIR
@ 2010-09-24 21:06 Eric Blake
2010-09-26 13:10 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Eric Blake @ 2010-09-24 21:06 UTC (permalink / raw)
To: kvm
I noticed today that various kvm source files are inconsistent on the
use of $TMP vs. $TMPDIR:
$ git grep -l '\$TMP\b' | cat
scripts/Kbuild.include
tools/perf/feature-tests.mak
$ git grep -l '\$TMPDIR\b' | cat
Documentation/lguest/extract
According to POSIX, you should probably be using $TMPDIR instead of $TMP
when referring to the preferred temporary directory location.
http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03
--
Eric Blake eblake@redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: inconsistent use of $TMP vs. $TMPDIR
2010-09-24 21:06 inconsistent use of $TMP vs. $TMPDIR Eric Blake
@ 2010-09-26 13:10 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2010-09-26 13:10 UTC (permalink / raw)
To: Eric Blake; +Cc: kvm
On 09/24/2010 11:06 PM, Eric Blake wrote:
> I noticed today that various kvm source files are inconsistent on the
> use of $TMP vs. $TMPDIR:
>
> $ git grep -l '\$TMP\b' | cat
> scripts/Kbuild.include
> tools/perf/feature-tests.mak
> $ git grep -l '\$TMPDIR\b' | cat
> Documentation/lguest/extract
>
> According to POSIX, you should probably be using $TMPDIR instead of
> $TMP when referring to the preferred temporary directory location.
>
> http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03
>
>
These are not kvm specific issues. Please use MAINTAINERS to report to
the maintainer of the affected subsystems (lguest, kbuild).
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-26 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-24 21:06 inconsistent use of $TMP vs. $TMPDIR Eric Blake
2010-09-26 13:10 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox