From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: inconsistent use of $TMP vs. $TMPDIR Date: Fri, 24 Sep 2010 15:06:40 -0600 Message-ID: <4C9D12E0.9050001@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48446 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753591Ab0IXVGl (ORCPT ); Fri, 24 Sep 2010 17:06:41 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8OL6fgP011672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 24 Sep 2010 17:06:41 -0400 Received: from [10.3.113.97] (ovpn-113-97.phx2.redhat.com [10.3.113.97]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8OL6eSZ032053 for ; Fri, 24 Sep 2010 17:06:40 -0400 Sender: kvm-owner@vger.kernel.org List-ID: I noticed today that various kvm source files are inconsistent on the use of $TMP vs. $TMPDIR: $ git grep -l '\$TMP\b' | cat scripts/Kbuild.include tools/perf/feature-tests.mak $ git grep -l '\$TMPDIR\b' | cat Documentation/lguest/extract According to POSIX, you should probably be using $TMPDIR instead of $TMP when referring to the preferred temporary directory location. http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03 -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org