From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH trace-cmd] plugin_kvm: disassemble instructions for kvm_emulate_insn Date: Sun, 26 Sep 2010 11:35:54 +0200 Message-ID: <4C9F13FA.9030405@redhat.com> References: <1284906837-2431-1-git-send-email-avi@redhat.com> <1285298684.31083.6.camel@gandalf.stny.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-users@vger.kernel.org To: Steven Rostedt Return-path: In-Reply-To: <1285298684.31083.6.camel@gandalf.stny.rr.com> Sender: linux-trace-users-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 09/24/2010 05:24 AM, Steven Rostedt wrote: > > > > Note 2: I get output of the form > > > > ... kvm_emulate_insn: 0:fffff800010527b5: mov $0x0, 0xfffe00b0CAN'T FIND FIELD "guest_rip" > > > > which leads me to believe there is a bug in trace_seq_printf when the input > > to %s is "". > > I ran this under gdb (nice to do that, where I don't in kernel :-) And > it takes me to kvm_emulate_insn_handler() which does the > trace_seq_printf() fine, but then calls pevent_print_num_field() and > that passes in "guest_rip" where we get the "CAN'T FIND FIELD" error. > > In pevent_print_num_field() it searches for "guest_rip" at the top of > the function (pevent_find_field()), but the event kvm_emulate_insn does > not have a "guest_rip" field, then it jumps to the error message. > > Gah, what idiot used copy-paste there? I'll post a patch to remove that line. -- error compiling committee.c: too many arguments to function