From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: inconsistent use of $TMP vs. $TMPDIR Date: Sun, 26 Sep 2010 15:10:20 +0200 Message-ID: <4C9F463C.9010102@redhat.com> References: <4C9D12E0.9050001@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Eric Blake Return-path: Received: from mx1.redhat.com ([209.132.183.28]:14857 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755005Ab0IZNK0 (ORCPT ); Sun, 26 Sep 2010 09:10:26 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8QDAPrY021157 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 26 Sep 2010 09:10:26 -0400 In-Reply-To: <4C9D12E0.9050001@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/24/2010 11:06 PM, Eric Blake wrote: > I noticed today that various kvm source files are inconsistent on the > use of $TMP vs. $TMPDIR: > > $ git grep -l '\$TMP\b' | cat > scripts/Kbuild.include > tools/perf/feature-tests.mak > $ git grep -l '\$TMPDIR\b' | cat > Documentation/lguest/extract > > According to POSIX, you should probably be using $TMPDIR instead of > $TMP when referring to the preferred temporary directory location. > > http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03 > > These are not kvm specific issues. Please use MAINTAINERS to report to the maintainer of the affected subsystems (lguest, kbuild). -- error compiling committee.c: too many arguments to function