From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/3] Add svm cpuid features Date: Mon, 27 Sep 2010 17:02:23 +0200 Message-ID: <4CA0B1FF.8040903@redhat.com> References: <1285593377-1754-1-git-send-email-joerg.roedel@amd.com> <1285593377-1754-4-git-send-email-joerg.roedel@amd.com> <4CA0B116.4070107@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Alexander Graf , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Joerg Roedel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54211 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759532Ab0I0PCe (ORCPT ); Mon, 27 Sep 2010 11:02:34 -0400 In-Reply-To: <4CA0B116.4070107@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/27/2010 04:58 PM, Avi Kivity wrote: > On 09/27/2010 03:16 PM, Joerg Roedel wrote: >> This patch adds the svm cpuid feature flags to the qemu >> intialization path. It also adds the svm features available >> on phenom to its cpu-definition and extends the host cpu >> type to support all svm features KVM can provide. >> > > This should really be "all svm features" since we'll later mask them > with kvm capabilities. This way, if we later add more capabilities, > we automatically gain support in userspace. > > (or rather, all svm features that don't need save/restore support in > userspace; I don't think any do, beyond svm itself) > I applied 2 and 3 (to branch uq/master). If you want to add more svm features, please send a patch. For patch 1, I'd like a review by someone who understands the compat code. -- error compiling committee.c: too many arguments to function