From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH 2/7] KVM: MMU: cleanup for error mask set while walk guest page table
Date: Tue, 28 Sep 2010 16:58:00 +0800 [thread overview]
Message-ID: <4CA1AE18.7070200@cn.fujitsu.com> (raw)
In-Reply-To: <4CA0AA7E.4090901@redhat.com>
On 09/27/2010 10:30 PM, Avi Kivity wrote:
>> r = FNAME(walk_addr)(&walker, vcpu, vaddr,
>> - !!(access& PFERR_WRITE_MASK),
>> - !!(access& PFERR_USER_MASK),
>> - !!(access& PFERR_FETCH_MASK));
>> + access& PFERR_WRITE_MASK,
>> + access& PFERR_USER_MASK,
>> + access& PFERR_FETCH_MASK);
>>
>> if (r) {
>> gpa = gfn_to_gpa(walker.gfn);
>
> Interesting. Maybe a next step is to pass the page-fault error code
> instead of the various bits?
Yeah, it's a good idea, i'll post a patch to do it.
> Not sure how that interacts with nested
> ept (which has a different permission model).
>
Umm, we just move the error code parsing from the caller site to FNAME(walk_addr)
function, i think it not make trouble for implement nested ept.
next prev parent reply other threads:[~2010-09-28 8:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 10:02 [PATCH 1/7] KVM: MMU: update 'root_hpa' out of loop in PAE shadow path Xiao Guangrong
2010-09-27 10:03 ` [PATCH 2/7] KVM: MMU: cleanup for error mask set while walk guest page table Xiao Guangrong
2010-09-27 14:30 ` Avi Kivity
2010-09-28 8:58 ` Xiao Guangrong [this message]
2010-09-28 9:00 ` Avi Kivity
2010-09-27 10:05 ` [PATCH 3/7] KVM: MMU: set access bit for direct mapping Xiao Guangrong
2010-09-27 10:07 ` [PATCH 5/7] KVM: MMU: audit: unregister audit tracepoints before module unloaded Xiao Guangrong
2010-09-27 10:07 ` [PATCH 6/7] KVM: MMU: audit: introduce audit_printk to cleanup audit code Xiao Guangrong
2010-09-27 10:09 ` [PATCH 7/7] KVM: MMU: audit: check whether have unsync sps after root sync Xiao Guangrong
2010-09-27 10:14 ` [PATCH 1/7] KVM: MMU: update 'root_hpa' out of loop in PAE shadow path Xiao Guangrong
2010-09-27 10:16 ` Avi Kivity
2010-09-27 14:39 ` Avi Kivity
2010-09-28 2:43 ` Xiao Guangrong
2010-09-28 9:03 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA1AE18.7070200@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox