From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/7] KVM: MMU: cleanup for error mask set while walk guest page table Date: Tue, 28 Sep 2010 11:00:58 +0200 Message-ID: <4CA1AECA.9090409@redhat.com> References: <4CA06BA4.4090303@cn.fujitsu.com> <4CA06BEF.7060401@cn.fujitsu.com> <4CA0AA7E.4090901@redhat.com> <4CA1AE18.7070200@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , LKML , KVM To: Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45940 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753701Ab0I1JBH (ORCPT ); Tue, 28 Sep 2010 05:01:07 -0400 In-Reply-To: <4CA1AE18.7070200@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/28/2010 10:58 AM, Xiao Guangrong wrote: > Yeah, it's a good idea, i'll post a patch to do it. > > > Not sure how that interacts with nested > > ept (which has a different permission model). > > > > Umm, we just move the error code parsing from the caller site to FNAME(walk_addr) > function, i think it not make trouble for implement nested ept. It means the nept code will have to take the ept error code and convert it to the standard error code. Not too difficult. -- error compiling committee.c: too many arguments to function