From: Avi Kivity <avi@redhat.com>
To: Zachary Amsden <zamsden@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Jan Kiszka <jan.kiszka@web.de>, kvm <kvm@vger.kernel.org>,
Glauber Costa <glommer@redhat.com>
Subject: Re: [PATCH] fix kvmclock bug
Date: Wed, 29 Sep 2010 10:58:05 +0200 [thread overview]
Message-ID: <4CA2FF9D.6080603@redhat.com> (raw)
In-Reply-To: <4C95560D.3050108@redhat.com>
On 09/19/2010 02:15 AM, Zachary Amsden wrote:
> commit 1abe7e8806fd71ea802c6622ed3ce7821a18f271
> Author: Zachary Amsden<zamsden@redhat.com>
> Date: Sat Sep 18 13:58:37 2010 -1000
>
> Fix kvmclock bug
I think there's some redundancy here. Anyone who has tracked your
kernel work knows you've done a lot of work on kvmclock, so "Fix bug"
would be just as descriptive. Of course, if we fix something, it's
because it was a bug, so "Fix" is all that's really necessary ("bug"
would be reserved for commits that introduce bugs). In the case of
kvmclock, it's hard to see how new features could be added, and it has a
pretty bad history of bugs, so most readers would probably deduce that a
commit fixes a bug. I don't really see why you wrote a subject line at all.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2010-09-29 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 0:15 [PATCH] fix kvmclock bug Zachary Amsden
2010-09-24 7:28 ` Jan Kiszka
2010-09-26 9:54 ` Jan Kiszka
2010-09-27 19:00 ` Zachary Amsden
2010-09-28 8:58 ` Jan Kiszka
2010-09-29 8:58 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA2FF9D.6080603@redhat.com \
--to=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox