From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arjan Koers <0h61vkll2ly8@xutrox.com>
Subject: Re: 2.6.35-rc1 regression with pvclock and smp guests
Date: Thu, 30 Sep 2010 22:16:10 +0200
Message-ID: <4CA4F00A.5020904@xutrox.com>
References: <4CA2F8A3.80400@redhat.com> <4CA30424.9030007@msgid.tls.msk.ru> <4CA30493.6090503@msgid.tls.msk.ru> <4CA392FE.5090009@xutrox.com> <4CA4427C.9090304@msgid.tls.msk.ru> <4CA45F7B.8050806@msgid.tls.msk.ru> <4CA4968F.9050402@redhat.com> <4CA4A8C5.3030407@msgid.tls.msk.ru> <4CA4AD87.8060502@redhat.com> <4CA4DBC8.6070606@xutrox.com> <20100930190507.GA1111@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Michael Tokarev <mjt@tls.msk.ru>,
	Zachary Amsden <zamsden@redhat.com>,
	Avi Kivity <avi@redhat.com>,
	Glauber Costa <glommer@redhat.com>,
	Andre Przywara <andre.przywara@amd.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from smtp-out3.tiscali.nl ([195.241.79.178]:49092 "EHLO
	smtp-out3.tiscali.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932088Ab0I3UQX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 30 Sep 2010 16:16:23 -0400
In-Reply-To: <20100930190507.GA1111@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 2010-09-30 21:05, Marcelo Tosatti wrote:
> 
> Arjan, Michael, can you try the following:
> 
> From 3823c018162dc708b543cbdc680a4c7d63533fee Mon Sep 17 00:00:00 2001
> From: Zachary Amsden <zamsden@redhat.com>
> Date: Sat, 29 May 2010 17:52:46 -1000
> Subject: [KVM V2 04/25] Fix SVM VMCB reset
> Cc: Avi Kivity <avi@redhat.com>,
>     Marcelo Tosatti <mtosatti@redhat.com>,
>     Glauber Costa <glommer@redhat.com>,
>     linux-kernel@vger.kernel.org
> 
> On reset, VMCB TSC should be set to zero.  Instead, code was setting
> tsc_offset to zero, which passes through the underlying TSC.
> 
> Signed-off-by: Zachary Amsden <zamsden@redhat.com>
> ---
>  arch/x86/kvm/svm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 760c86e..46856d2 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -781,7 +781,7 @@ static void init_vmcb(struct vcpu_svm *svm)
>  
>  	control->iopm_base_pa = iopm_base;
>  	control->msrpm_base_pa = __pa(svm->msrpm);
> -	control->tsc_offset = 0;
> +	guest_write_tsc(&svm->vcpu, 0);
>  	control->int_ctl = V_INTR_MASKING_MASK;
>  
>  	init_seg(&save->es);

It doesn't solve my problem. I tried on 2.6.32.23 and 2.6.36-rc6.