From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tokarev Subject: Re: 2.6.35-rc1 regression with pvclock and smp guests Date: Fri, 01 Oct 2010 03:07:51 +0400 Message-ID: <4CA51847.5060208@msgid.tls.msk.ru> References: <4CA2F8A3.80400@redhat.com> <4CA30424.9030007@msgid.tls.msk.ru> <4CA30493.6090503@msgid.tls.msk.ru> <4CA392FE.5090009@xutrox.com> <4CA4427C.9090304@msgid.tls.msk.ru> <4CA45F7B.8050806@msgid.tls.msk.ru> <4CA4968F.9050402@redhat.com> <4CA4A8C5.3030407@msgid.tls.msk.ru> <4CA4AD87.8060502@redhat.com> <4CA4DBC8.6070606@xutrox.com> <20100930190507.GA1111@amt.cnet> <4CA51715.1070507@msgid.tls.msk.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Arjan Koers <0h61vkll2ly8@xutrox.com>, kvm@vger.kernel.org, Zachary Amsden , Avi Kivity , Glauber Costa , Andre Przywara To: Marcelo Tosatti Return-path: Received: from isrv.corpit.ru ([86.62.121.231]:33661 "EHLO isrv.corpit.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081Ab0I3XHy (ORCPT ); Thu, 30 Sep 2010 19:07:54 -0400 In-Reply-To: <4CA51715.1070507@msgid.tls.msk.ru> Sender: kvm-owner@vger.kernel.org List-ID: 01.10.2010 03:02, Michael Tokarev wrote: > 30.09.2010 23:05, Marcelo Tosatti wrote: > [] >> Arjan, Michael, can you try the following: >> >> From 3823c018162dc708b543cbdc680a4c7d63533fee Mon Sep 17 00:00:00 20= 01 >> From: Zachary Amsden >> Date: Sat, 29 May 2010 17:52:46 -1000 >> Subject: [KVM V2 04/25] Fix SVM VMCB reset >> Cc: Avi Kivity , >> Marcelo Tosatti , >> Glauber Costa , >> linux-kernel@vger.kernel.org >> >> On reset, VMCB TSC should be set to zero. Instead, code was setting >> tsc_offset to zero, which passes through the underlying TSC. >> >> Signed-off-by: Zachary Amsden >> --- >> arch/x86/kvm/svm.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c >> index 760c86e..46856d2 100644 >> --- a/arch/x86/kvm/svm.c >> +++ b/arch/x86/kvm/svm.c >> @@ -781,7 +781,7 @@ static void init_vmcb(struct vcpu_svm *svm) >> =20 >> control->iopm_base_pa =3D iopm_base; >> control->msrpm_base_pa =3D __pa(svm->msrpm); >> - control->tsc_offset =3D 0; >> + guest_write_tsc(&svm->vcpu, 0); >> control->int_ctl =3D V_INTR_MASKING_MASK; >=20 > This fails to compile on 2.6.35.5: >=20 > arch/x86/kvm/svm.c: In function =91init_vmcb=92: > arch/x86/kvm/svm.c:769: error: implicit declaration of function =91gu= est_write_tsc=92 >=20 > I'll take a look tomorrow where that comes from.. hopefully ;) Ok, that routine is static, defined in arch/x86/kvm/vmx.c (not svm.c). I'm not sure it's ok to use it in svm.c directly, as it appears to be vmx-specific. Thanks! /mjt