From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Monitor command to translate guest physical address to host virtual address Date: Sun, 03 Oct 2010 12:07:18 +0200 Message-ID: <4CA855D6.8040609@redhat.com> References: <1285897945.24402.5.camel@yhuang-dev> <20101001225334.GB31596@amt.cnet> <4CA6EA4F.8020201@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Huang Ying , "kvm@vger.kernel.org" , Andi Kleen , Dean Nelson To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49149 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239Ab0JCKHa (ORCPT ); Sun, 3 Oct 2010 06:07:30 -0400 In-Reply-To: <4CA6EA4F.8020201@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/02/2010 10:16 AM, Avi Kivity wrote: > On 10/02/2010 12:53 AM, Marcelo Tosatti wrote: >> On Fri, Oct 01, 2010 at 09:52:25AM +0800, Huang Ying wrote: >> > From: Max Asbock >> > >> > Add command p2v to translate guest physical address to host virtual >> > address. >> > >> > The p2v command provides one step in a chain of translations from >> > guest virtual to guest physical to host virtual to host physical. >> Host >> > physical is then used to inject a machine check error. As a >> > consequence the HWPOISON code on the host and the MCE injection code >> > in qemu-kvm are exercised. >> > >> > Signed-off-by: Max Asbock >> > Signed-off-by: Jiajia Zheng >> > Signed-off-by: Huang Ying >> >> Added missing cpu_physical_memory_unmap and applied, thanks. >> > > This should have been copied to qemu-devel so that the monitor people > can review it. > It also breaks the build: > > I CC x86_64-softmmu/monitor.o > cc1: warnings being treated as errors > /var/lib/buildbot/qemu-kvm/disable_kvm_i386_out_of_tree/build/monitor.c: > In function 'do_p2v': > /var/lib/buildbot/qemu-kvm/disable_kvm_i386_out_of_tree/build/monitor.c:2312: > error: cast to pointer from integer of different size > make[1]: *** [monitor.o] Error 1 > make: *** [subdir-x86_64-softmmu] Error 2 I've reverted it for now. Please resubmit to qemu upstream (qemu-devel@nongnu.org). I also suggest coming up with a better name for the command, and QMP support. -- error compiling committee.c: too many arguments to function