From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [patch uq/master 4/8] kvm: x86: add mce support Date: Wed, 06 Oct 2010 14:32:24 -0500 Message-ID: <4CACCEC8.9050109@codemonkey.ws> References: <20101006173424.425523999@redhat.com> <20101006173609.474173698@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, Huang Ying , Dean Nelson To: Marcelo Tosatti Return-path: Received: from mail-qy0-f174.google.com ([209.85.216.174]:53007 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759887Ab0JFTcr (ORCPT ); Wed, 6 Oct 2010 15:32:47 -0400 Received: by qyk29 with SMTP id 29so3550492qyk.19 for ; Wed, 06 Oct 2010 12:32:46 -0700 (PDT) In-Reply-To: <20101006173609.474173698@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/06/2010 12:34 PM, Marcelo Tosatti wrote: > Port qemu-kvm's MCE support > > commit c68b2374c9048812f488e00ffb95db66c0bc07a7 > Author: Huang Ying > Date: Mon Jul 20 10:00:53 2009 +0800 > > Add MCE simulation support to qemu/kvm > > KVM ioctls are used to initialize MCE simulation and inject MCE. The > real MCE simulation is implemented in Linux kernel. The Kernel part > has been merged. > > Signed-off-by: Marcelo Tosatti > > Index: qemu/target-i386/helper.c > =================================================================== > --- qemu.orig/target-i386/helper.c > +++ qemu/target-i386/helper.c > @@ -27,6 +27,7 @@ > #include "exec-all.h" > #include "qemu-common.h" > #include "kvm.h" > +#include "kvm_x86.h" > > //#define DEBUG_MMU > > @@ -1030,6 +1031,11 @@ void cpu_inject_x86_mce(CPUState *cenv, > if (bank>= bank_num || !(status& MCI_STATUS_VAL)) > return; > > + if (kvm_enabled()) { > + kvm_inject_x86_mce(cenv, bank, status, mcg_status, addr, misc); > + return; > + } > + > /* > * if MSR_MCG_CTL is not all 1s, the uncorrected error > * reporting is disabled > Index: qemu/target-i386/kvm.c > =================================================================== > --- qemu.orig/target-i386/kvm.c > +++ qemu/target-i386/kvm.c > @@ -27,6 +27,7 @@ > #include "hw/pc.h" > #include "hw/apic.h" > #include "ioport.h" > +#include "kvm_x86.h" > > #ifdef CONFIG_KVM_PARA > #include > @@ -167,6 +168,67 @@ static int get_para_features(CPUState *e > } > #endif > > +#ifdef KVM_CAP_MCE > +static int kvm_get_mce_cap_supported(KVMState *s, uint64_t *mce_cap, > + int *max_banks) > +{ > + int r; > + > + r = kvm_ioctl(s, KVM_CHECK_EXTENSION, KVM_CAP_MCE); > + if (r> 0) { > + *max_banks = r; > + return kvm_ioctl(s, KVM_X86_GET_MCE_CAP_SUPPORTED, mce_cap); > + } > + return -ENOSYS; > +} > + > +static int kvm_setup_mce(CPUState *env, uint64_t *mcg_cap) > +{ > + return kvm_vcpu_ioctl(env, KVM_X86_SETUP_MCE, mcg_cap); > +} > + > +static int kvm_set_mce(CPUState *env, struct kvm_x86_mce *m) > +{ > + return kvm_vcpu_ioctl(env, KVM_X86_SET_MCE, m); > +} > + > +struct kvm_x86_mce_data > +{ > + CPUState *env; > + struct kvm_x86_mce *mce; > +}; > + > +static void kvm_do_inject_x86_mce(void *_data) > +{ > + struct kvm_x86_mce_data *data = _data; > + int r; > + > + r = kvm_set_mce(data->env, data->mce); > + if (r< 0) > + perror("kvm_set_mce FAILED"); > +} > +#endif > + > +void kvm_inject_x86_mce(CPUState *cenv, int bank, uint64_t status, > + uint64_t mcg_status, uint64_t addr, uint64_t misc) > +{ > +#ifdef KVM_CAP_MCE > + struct kvm_x86_mce mce = { > + .bank = bank, > + .status = status, > + .mcg_status = mcg_status, > + .addr = addr, > + .misc = misc, > + }; > + struct kvm_x86_mce_data data = { > + .env = cenv, > + .mce =&mce, > + }; > + > + run_on_cpu(cenv, kvm_do_inject_x86_mce,&data); > +#endif > +} > + > int kvm_arch_init_vcpu(CPUState *env) > { > struct { > @@ -274,6 +336,28 @@ int kvm_arch_init_vcpu(CPUState *env) > > cpuid_data.cpuid.nent = cpuid_i; > > +#ifdef KVM_CAP_MCE > + if (((env->cpuid_version>> 8)&0xF)>= 6 > +&& (env->cpuid_features&(CPUID_MCE|CPUID_MCA)) == (CPUID_MCE|CPUID_MCA) > +&& kvm_check_extension(env->kvm_state, KVM_CAP_MCE)> 0) { > + uint64_t mcg_cap; > + int banks; > + > + if (kvm_get_mce_cap_supported(env->kvm_state,&mcg_cap,&banks)) > + perror("kvm_get_mce_cap_supported FAILED"); > + else { > + if (banks> MCE_BANKS_DEF) > + banks = MCE_BANKS_DEF; > + mcg_cap&= MCE_CAP_DEF; > + mcg_cap |= banks; > + if (kvm_setup_mce(env,&mcg_cap)) > + perror("kvm_setup_mce FAILED"); > + else > + env->mcg_cap = mcg_cap; > + } > + } > +#endif > + > return kvm_vcpu_ioctl(env, KVM_SET_CPUID2,&cpuid_data); > } > > Index: qemu/target-i386/kvm_x86.h > =================================================================== > --- /dev/null > +++ qemu/target-i386/kvm_x86.h > @@ -0,0 +1,21 @@ > +/* > + * QEMU KVM support > + * > + * Copyright (C) 2009 Red Hat Inc. > + * Copyright IBM, Corp. 2008 > + * > + * Authors: > + * Anthony Liguori > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + * > + */ > BTW, I'm fairly sure I didn't write any of this code so this copyright statement is probably bogus. Regards, Anthony Liguori > + > +#ifndef __KVM_X86_H__ > +#define __KVM_X86_H__ > + > +void kvm_inject_x86_mce(CPUState *cenv, int bank, uint64_t status, > + uint64_t mcg_status, uint64_t addr, uint64_t misc); > + > +#endif > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >