From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zachary Amsden Subject: Re: 2.6.35-rc1 regression with pvclock and smp guests Date: Thu, 07 Oct 2010 16:47:11 -1000 Message-ID: <4CAE862F.10904@redhat.com> References: <4CA2F8A3.80400@redhat.com> <4CA30424.9030007@msgid.tls.msk.ru> <4CA30493.6090503@msgid.tls.msk.ru> <4CA392FE.5090009@xutrox.com> <4CA4427C.9090304@msgid.tls.msk.ru> <4CA45F7B.8050806@msgid.tls.msk.ru> <4CA4968F.9050402@redhat.com> <4CA4A8C5.3030407@msgid.tls.msk.ru> <4CA4AD87.8060502@redhat.com> <4CA4DBC8.6070606@xutrox.com> <20100930190507.GA1111@amt.cnet> <4CA51715.1070507@msgid.tls.msk.ru> <4CA51847.5060208@msgid.tls.msk.ru> <4CA6C4BB.5020004@redhat.com> <4CA6E0BF.90605@msgid.tls.msk.ru> <4CA75969.1080405@xutrox.com> <4CA7C34C.4040000@redhat.com> <4CAE6203.6040902@xutrox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti , Michael Tokarev , Avi Kivity , Glauber Costa , Andre Przywara To: Arjan Koers <0h61vkll2ly8@xutrox.com> Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31552 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042Ab0JHCrW (ORCPT ); Thu, 7 Oct 2010 22:47:22 -0400 In-Reply-To: <4CAE6203.6040902@xutrox.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/07/2010 02:12 PM, Arjan Koers wrote: > On 2010-10-03 01:42, Zachary Amsden wrote: > ... > >> Umm... do you guys have this commit? This is supposed to address the >> issue where the guest keeps resetting the TSC. A guest which does that >> will break kvmclock. It only happens on SMP, and it's much worse on AMD >> CPUs... >> >> sound like your scenario. >> >> commit bd59fc8ff95126f27b7a0df1b6cc602aa428812d >> Author: Zachary Amsden >> Date: Thu Aug 19 22:07:26 2010 -1000 >> > > This commit fixes the problem: > > commit aad07c4f92bae2edaa42bcef84c2afdd0d082458 > Author: Zachary Amsden > Date: Thu Aug 19 22:07:19 2010 -1000 > > KVM: x86: Move TSC reset out of vmcb_init > > The VMCB is reset whenever we receive a startup IPI, so Linux is setting > TSC back to zero happens very late in the boot process and destabilizing > the TSC. Instead, just set TSC to zero once at VCPU creation time. > > Why the separate patch? So git-bisect is your friend. > Okay, apparently I need to go poke around 2.6.35 and see what patches made it there and what patches didn't.