From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] Hitting 29 NIC limit Date: Thu, 14 Oct 2010 15:23:22 +0200 Message-ID: <4CB7044A.4050705@redhat.com> References: <4CB6388A.30006@codemonkey.ws> <4CB6F275.2060204@redhat.com> <4CB6FD7E.7010606@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anjali Kulkarni , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47656 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754435Ab0JNNXw (ORCPT ); Thu, 14 Oct 2010 09:23:52 -0400 In-Reply-To: <4CB6FD7E.7010606@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 10/14/2010 02:54 PM, Anthony Liguori wrote: >>> The key is to make the virtio-net devices multifunction and to fill >>> out all 8 functions for each slot. >> >> This is unlikely to work right wrt pci hotplug. > > > Yes. Our hotplug design is based on devices.. This is wrong, it > should be based on bus-level concepts (like PCI slots). > >> If we want to support a large number of interfaces, we need true >> multiport cards. > > This magic here creates a multiport virtio-net card so I'm not really > sure what you're suggesting. It would certainly be nice to make this > all more user friendly (and make hotplug work). > The big issue is to fix hotplug. I don't see how we can make it user friendly, without making the ordinary case even more unfriendly. Looks like we need yet another level of indirection here. -- error compiling committee.c: too many arguments to function