From: Jan Kiszka <jan.kiszka@siemens.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
Joerg Roedel <joerg.roedel@amd.com>
Subject: Re: [PATCH] KVM: Fix signature of kvm_iommu_map_pages stub
Date: Mon, 18 Oct 2010 15:11:45 +0200 [thread overview]
Message-ID: <4CBC4791.8020504@siemens.com> (raw)
In-Reply-To: <20101018130400.GD29108@amt.cnet>
Am 18.10.2010 15:04, Marcelo Tosatti wrote:
> On Thu, Oct 14, 2010 at 02:43:51PM +0200, Jan Kiszka wrote:
>> Am 14.10.2010 13:59, Jan Kiszka wrote:
>>> Breaks otherwise if CONFIG_IOMMU_API is not set.
>>
>> Actually, it only broke a special local version. It doesn't break with
>> current KVM due to
>>
>> [__kvm_set_memory_region:]
>> #ifdef CONFIG_DMAR
>> /* map the pages in iommu page table */
>> if (npages) {
>> r = kvm_iommu_map_pages(kvm, &new);
>> if (r)
>> goto out_free;
>> }
>> #endif
>>
>> And CONFIG_IOMMU_API is set when CONFIG_DMAR is enabled. But do we only
>> need this call on Intel?
>
> On CONFIG_AMD_IOMMU too. It should be conditional on CONFIG_IOMMU_API.
>
Then we can simply drop the #ifdef here as kvm_iommu_map_pages is
stubbed for !CONFIG_IOMMU_API.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2010-10-18 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 11:59 [PATCH] KVM: Fix signature of kvm_iommu_map_pages stub Jan Kiszka
2010-10-14 12:43 ` Jan Kiszka
2010-10-18 13:04 ` Marcelo Tosatti
2010-10-18 13:11 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBC4791.8020504@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox