From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Add support for async page fault to qemu Date: Mon, 18 Oct 2010 17:53:28 +0200 Message-ID: <4CBC6D78.6090306@redhat.com> References: <20101018132538.GC10207@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Juan Quintela Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58492 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755222Ab0JRPxd (ORCPT ); Mon, 18 Oct 2010 11:53:33 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 10/18/2010 05:48 PM, Juan Quintela wrote: > Gleb Natapov wrote: > > Add save/restore of MSR for migration and cpuid bit. > > It is there a way to test if async page faults are in use? Yes, msr != 0 -> need a subsection. Good idea. > if so, we can add a subsection instead of changing the cpuversion. > > I think that at some point we are going to need a bitmap that indicates > what MSR's have been used or something like that. > > What do you think? We just need to check if an msr is different from its default value (which we can get by reading msrs immediately after the initial reset). Currently the reset code assumes msr reset value is zero, that's wrong. -- error compiling committee.c: too many arguments to function