Re: [PATCH] KVM Test: Set bootstatuspolicy to ignoreallfailures for Win2008 and r2 in autounattend.xml

Michael Goldish
2010-10-20T10:29:44Z

On 10/20/2010 11:47 AM, Feng Yang wrote:
>
> ----- "Michael Goldish" <mgoldish@redhat.com> wrote:
>
>> From: "Michael Goldish" <mgoldish@redhat.com>
>> To: "Feng Yang" <fyang@redhat.com>
>> Cc: autotest@test.kernel.org, kvm@vger.kernel.org
>> Sent: Wednesday, October 20, 2010 4:49:29 PM GMT +08:00 Beijing / Chongqing / Hong Kong / Urumqi
>> Subject: Re: [PATCH] KVM Test: Set bootstatuspolicy to ignoreallfailures for Win2008 and r2 in autounattend.xml
>>
>> On 10/20/2010 07:53 AM, Feng Yang wrote:
>>> Windows 2008 image is easy to go to startup repair screen, which
>> make
>>> many of our cases fail. This patch will disable startup repair
>> screen
>>> in win2008 which caused by shutdown failures.
>>>
>>> Signed-off-by: Feng Yang <fyang@redhat.com>
>>
>> Shouldn't it be easier to add the line to setuprss.bat? Or do you
>> specifically want to target win2008?
>
> Thanks for your comment.
>
> There is not bcdedit command in older windows, e.g. 2003. So we'd better do not add the line to setuprss.bat.

setuprss.bat already has a few commands that only work on some Windows
versions. They fail silently and that's fine. Still, I suppose adding
bcdedit to the xml is also fine. We can change it later.

>>> .../kvm/unattended/win2008-32-autounattend.xml | 10
>> +++++++---
>>> .../kvm/unattended/win2008-64-autounattend.xml | 10
>> +++++++---
>>> .../kvm/unattended/win2008-r2-autounattend.xml | 10
>> +++++++---
>>> 3 files changed, 21 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/client/tests/kvm/unattended/win2008-32-autounattend.xml
>> b/client/tests/kvm/unattended/win2008-32-autounattend.xml
>>> index 89af07f..7e8e160 100644
>>> --- a/client/tests/kvm/unattended/win2008-32-autounattend.xml
>>> +++ b/client/tests/kvm/unattended/win2008-32-autounattend.xml
>>> @@ -149,16 +149,20 @@
>>> <Order>5</Order>
>>> </SynchronousCommand>
>>> <SynchronousCommand wcm:action="add">
>>> + <CommandLine>%WINDIR%\System32\cmd /c bcdedit /set {current}
>> bootstatuspolicy ignoreallfailures</CommandLine>
>>> + <Order>6</Order>
>>> + </SynchronousCommand>
>>> + <SynchronousCommand wcm:action="add">
>>> <CommandLine>%WINDIR%\System32\cmd /c
>> E:\setuprss.bat</CommandLine>
>>> - <Order>6</Order>
>>> + <Order>7</Order>
>>> </SynchronousCommand>
>>> <SynchronousCommand wcm:action="add">
>>> <CommandLine>%WINDIR%\System32\cmd /c netsh interface ip set
>> address "Local Area Connection" dhcp</CommandLine>
>>> - <Order>7</Order>
>>> + <Order>8</Order>
>>> </SynchronousCommand>
>>> <SynchronousCommand wcm:action="add">
>>> <CommandLine>%WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20
>> &#38;&#38; A:\finish.exe</CommandLine>
>>> - <Order>8</Order>
>>> + <Order>9</Order>
>>> </SynchronousCommand>
>>> </FirstLogonCommands>
>>> <OOBE>
>>> diff --git a/client/tests/kvm/unattended/win2008-64-autounattend.xml
>> b/client/tests/kvm/unattended/win2008-64-autounattend.xml
>>> index 98f5589..fce6582 100644
>>> --- a/client/tests/kvm/unattended/win2008-64-autounattend.xml
>>> +++ b/client/tests/kvm/unattended/win2008-64-autounattend.xml
>>> @@ -158,17 +158,21 @@
>>> <Order>5</Order>
>>> </SynchronousCommand>
>>> <SynchronousCommand wcm:action="add">
>>> - <CommandLine>%WINDIR%\System32\cmd /c
>> E:\setuprss.bat</CommandLine>
>>> + <CommandLine>%WINDIR%\System32\cmd /c bcdedit /set {current}
>> bootstatuspolicy ignoreallfailures</CommandLine>
>>> <Order>6</Order>
>>> </SynchronousCommand>
>>> <SynchronousCommand wcm:action="add">
>>> - <CommandLine>%WINDIR%\System32\cmd /c netsh interface ip set
>> address "Local Area Connection" dhcp</CommandLine>
>>> + <CommandLine>%WINDIR%\System32\cmd /c
>> E:\setuprss.bat</CommandLine>
>>> <Order>7</Order>
>>> </SynchronousCommand>
>>> <SynchronousCommand wcm:action="add">
>>> - <CommandLine>%WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20
>> &#38;&#38; A:\finish.exe</CommandLine>
>>> + <CommandLine>%WINDIR%\System32\cmd /c netsh interface ip set
>> address "Local Area Connection" dhcp</CommandLine>
>>> <Order>8</Order>
>>> </SynchronousCommand>
>>> + <SynchronousCommand wcm:action="add">
>>> + <CommandLine>%WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20
>> &#38;&#38; A:\finish.exe</CommandLine>
>>> + <Order>9</Order>
>>> + </SynchronousCommand>
>>> </FirstLogonCommands>
>>> <OOBE>
>>> <HideEULAPage>true</HideEULAPage>
>>> diff --git a/client/tests/kvm/unattended/win2008-r2-autounattend.xml
>> b/client/tests/kvm/unattended/win2008-r2-autounattend.xml
>>> index b624d10..948e9a1 100644
>>> --- a/client/tests/kvm/unattended/win2008-r2-autounattend.xml
>>> +++ b/client/tests/kvm/unattended/win2008-r2-autounattend.xml
>>> @@ -158,17 +158,21 @@
>>> <Order>5</Order>
>>> </SynchronousCommand>
>>> <SynchronousCommand wcm:action="add">
>>> - <CommandLine>%WINDIR%\System32\cmd /c
>> E:\setuprss.bat</CommandLine>
>>> + <CommandLine>%WINDIR%\System32\cmd /c bcdedit /set {current}
>> bootstatuspolicy ignoreallfailures</CommandLine>
>>> <Order>6</Order>
>>> </SynchronousCommand>
>>> <SynchronousCommand wcm:action="add">
>>> - <CommandLine>%WINDIR%\System32\cmd /c netsh interface ip set
>> address "Local Area Connection" dhcp</CommandLine>
>>> + <CommandLine>%WINDIR%\System32\cmd /c
>> E:\setuprss.bat</CommandLine>
>>> <Order>7</Order>
>>> </SynchronousCommand>
>>> <SynchronousCommand wcm:action="add">
>>> - <CommandLine>%WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20
>> &#38;&#38; A:\finish.exe</CommandLine>
>>> + <CommandLine>%WINDIR%\System32\cmd /c netsh interface ip set
>> address "Local Area Connection" dhcp</CommandLine>
>>> <Order>8</Order>
>>> </SynchronousCommand>
>>> + <SynchronousCommand wcm:action="add">
>>> + <CommandLine>%WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20
>> &#38;&#38; A:\finish.exe</CommandLine>
>>> + <Order>9</Order>
>>> + </SynchronousCommand>
>>> </FirstLogonCommands>
>>> <OOBE>
>>> <HideEULAPage>true</HideEULAPage>