Re: [patch 1/3] KVM: VMX: remove setting of shadow_base_ptes for EPT

[Avi Kivity <avi@redhat.com>]

  On 10/19/2010 06:26 PM, Marcelo Tosatti wrote:
> The EPT present/writable bits use the same position as normal
> pagetable bits.
>
> Since direct_map passes ACC_ALL to mmu_set_spte, thus always setting
> the writable bit on sptes, use the generic PT_PRESENT shadow_base_pte.
>
> Also pass present/writable error code information from EPT violation
> to generic pagefault handler.
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>
> Index: kvm/arch/x86/kvm/vmx.c
> ===================================================================
> --- kvm.orig/arch/x86/kvm/vmx.c
> +++ kvm/arch/x86/kvm/vmx.c
> @@ -3483,7 +3483,7 @@ static int handle_ept_violation(struct k
>
>   	gpa = vmcs_read64(GUEST_PHYSICAL_ADDRESS);
>   	trace_kvm_page_fault(gpa, exit_qualification);
> -	return kvm_mmu_page_fault(vcpu, gpa&  PAGE_MASK, 0);
> +	return kvm_mmu_page_fault(vcpu, gpa, exit_qualification&  0x3);
>   }

Why in the same patch?  Seems unrelated.

Ah, it's actually not unrelated, it won't work without it.


>
>   static u64 ept_rsvd_mask(u64 spte, int level)
> @@ -4408,8 +4408,6 @@ static int __init vmx_init(void)
>
>   	if (enable_ept) {
>   		bypass_guest_pf = 0;
> -		kvm_mmu_set_base_ptes(VMX_EPT_READABLE_MASK |
> -			VMX_EPT_WRITABLE_MASK);
>   		kvm_mmu_set_mask_ptes(0ull, 0ull, 0ull, 0ull,
>   				VMX_EPT_EXECUTABLE_MASK);
>   		kvm_enable_tdp();
>

Only caller gone, please remove callee.


-- 
error compiling committee.c: too many arguments to function