From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Goldish Subject: Re: [PATCH] KVM Test: Set bootstatuspolicy to ignoreallfailures for Win2008 and r2 in autounattend.xml Date: Wed, 20 Oct 2010 12:29:40 +0200 Message-ID: <4CBEC494.5010508@redhat.com> References: <1369003334.994761287568068890.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Feng Yang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26253 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756Ab0JTK3o (ORCPT ); Wed, 20 Oct 2010 06:29:44 -0400 In-Reply-To: <1369003334.994761287568068890.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/20/2010 11:47 AM, Feng Yang wrote: > > ----- "Michael Goldish" wrote: > >> From: "Michael Goldish" >> To: "Feng Yang" >> Cc: autotest@test.kernel.org, kvm@vger.kernel.org >> Sent: Wednesday, October 20, 2010 4:49:29 PM GMT +08:00 Beijing / Chongqing / Hong Kong / Urumqi >> Subject: Re: [PATCH] KVM Test: Set bootstatuspolicy to ignoreallfailures for Win2008 and r2 in autounattend.xml >> >> On 10/20/2010 07:53 AM, Feng Yang wrote: >>> Windows 2008 image is easy to go to startup repair screen, which >> make >>> many of our cases fail. This patch will disable startup repair >> screen >>> in win2008 which caused by shutdown failures. >>> >>> Signed-off-by: Feng Yang >> >> Shouldn't it be easier to add the line to setuprss.bat? Or do you >> specifically want to target win2008? > > Thanks for your comment. > > There is not bcdedit command in older windows, e.g. 2003. So we'd better do not add the line to setuprss.bat. setuprss.bat already has a few commands that only work on some Windows versions. They fail silently and that's fine. Still, I suppose adding bcdedit to the xml is also fine. We can change it later. >>> .../kvm/unattended/win2008-32-autounattend.xml | 10 >> +++++++--- >>> .../kvm/unattended/win2008-64-autounattend.xml | 10 >> +++++++--- >>> .../kvm/unattended/win2008-r2-autounattend.xml | 10 >> +++++++--- >>> 3 files changed, 21 insertions(+), 9 deletions(-) >>> >>> diff --git a/client/tests/kvm/unattended/win2008-32-autounattend.xml >> b/client/tests/kvm/unattended/win2008-32-autounattend.xml >>> index 89af07f..7e8e160 100644 >>> --- a/client/tests/kvm/unattended/win2008-32-autounattend.xml >>> +++ b/client/tests/kvm/unattended/win2008-32-autounattend.xml >>> @@ -149,16 +149,20 @@ >>> 5 >>> >>> >>> + %WINDIR%\System32\cmd /c bcdedit /set {current} >> bootstatuspolicy ignoreallfailures >>> + 6 >>> + >>> + >>> %WINDIR%\System32\cmd /c >> E:\setuprss.bat >>> - 6 >>> + 7 >>> >>> >>> %WINDIR%\System32\cmd /c netsh interface ip set >> address "Local Area Connection" dhcp >>> - 7 >>> + 8 >>> >>> >>> %WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 >> && A:\finish.exe >>> - 8 >>> + 9 >>> >>> >>> >>> diff --git a/client/tests/kvm/unattended/win2008-64-autounattend.xml >> b/client/tests/kvm/unattended/win2008-64-autounattend.xml >>> index 98f5589..fce6582 100644 >>> --- a/client/tests/kvm/unattended/win2008-64-autounattend.xml >>> +++ b/client/tests/kvm/unattended/win2008-64-autounattend.xml >>> @@ -158,17 +158,21 @@ >>> 5 >>> >>> >>> - %WINDIR%\System32\cmd /c >> E:\setuprss.bat >>> + %WINDIR%\System32\cmd /c bcdedit /set {current} >> bootstatuspolicy ignoreallfailures >>> 6 >>> >>> >>> - %WINDIR%\System32\cmd /c netsh interface ip set >> address "Local Area Connection" dhcp >>> + %WINDIR%\System32\cmd /c >> E:\setuprss.bat >>> 7 >>> >>> >>> - %WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 >> && A:\finish.exe >>> + %WINDIR%\System32\cmd /c netsh interface ip set >> address "Local Area Connection" dhcp >>> 8 >>> >>> + >>> + %WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 >> && A:\finish.exe >>> + 9 >>> + >>> >>> >>> true >>> diff --git a/client/tests/kvm/unattended/win2008-r2-autounattend.xml >> b/client/tests/kvm/unattended/win2008-r2-autounattend.xml >>> index b624d10..948e9a1 100644 >>> --- a/client/tests/kvm/unattended/win2008-r2-autounattend.xml >>> +++ b/client/tests/kvm/unattended/win2008-r2-autounattend.xml >>> @@ -158,17 +158,21 @@ >>> 5 >>> >>> >>> - %WINDIR%\System32\cmd /c >> E:\setuprss.bat >>> + %WINDIR%\System32\cmd /c bcdedit /set {current} >> bootstatuspolicy ignoreallfailures >>> 6 >>> >>> >>> - %WINDIR%\System32\cmd /c netsh interface ip set >> address "Local Area Connection" dhcp >>> + %WINDIR%\System32\cmd /c >> E:\setuprss.bat >>> 7 >>> >>> >>> - %WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 >> && A:\finish.exe >>> + %WINDIR%\System32\cmd /c netsh interface ip set >> address "Local Area Connection" dhcp >>> 8 >>> >>> + >>> + %WINDIR%\System32\cmd /c ping 10.0.2.2 -n 20 >> && A:\finish.exe >>> + 9 >>> + >>> >>> >>> true