From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, aarcange@redhat.com
Subject: Re: [patch 3/3] KVM: propagate fault r/w information to gup(), allow read-only mappings
Date: Wed, 20 Oct 2010 12:36:34 +0200 [thread overview]
Message-ID: <4CBEC632.8090600@redhat.com> (raw)
In-Reply-To: <20101019162726.570196410@redhat.com>
On 10/19/2010 06:26 PM, Marcelo Tosatti wrote:
> As suggested by Andrea, pass r/w error code to gup(), upgrading read fault
> to writable if host pte allows it.
>
Looks good.
>
> static pfn_t hva_to_pfn(struct kvm *kvm, unsigned long addr, bool atomic,
> - bool *async)
> + bool *async, bool write_fault, bool *writable)
These sort of changes make reading the callers impossible, lots of
true/false and NULL parameters which we have no idea what they mean.
We should (later) change the functions to accept a structure with named
fields for these parameters instead.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-10-20 10:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 16:26 [patch 0/3] [RFC] support read-only mappings Marcelo Tosatti
2010-10-19 16:26 ` [patch 1/3] KVM: VMX: remove setting of shadow_base_ptes for EPT Marcelo Tosatti
2010-10-20 10:24 ` Avi Kivity
2010-10-19 16:26 ` [patch 2/3] KVM: MMU: flush TLBs on writable -> read-only spte overwrite Marcelo Tosatti
2010-10-19 16:26 ` [patch 3/3] KVM: propagate fault r/w information to gup(), allow read-only mappings Marcelo Tosatti
2010-10-20 10:36 ` Avi Kivity [this message]
2010-10-22 16:18 ` [patch 0/4] support read-only mappings (v2) Marcelo Tosatti
2010-10-22 16:18 ` [patch 1/4] KVM: VMX: remove setting of shadow_base_ptes for EPT Marcelo Tosatti
2010-10-22 16:18 ` [patch 2/4] KVM: MMU: remove kvm_mmu_set_base_ptes Marcelo Tosatti
2010-10-22 16:18 ` [patch 3/4] KVM: MMU: flush TLBs on writable -> read-only spte overwrite Marcelo Tosatti
2010-10-22 16:18 ` [patch 4/4] KVM: propagate fault r/w information to gup(), allow read-only memory Marcelo Tosatti
2010-10-27 9:20 ` [patch 0/4] support read-only mappings (v2) Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBEC632.8090600@redhat.com \
--to=avi@redhat.com \
--cc=aarcange@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox