From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] KVM: Move KVM context switch into own function
Date: Wed, 20 Oct 2010 18:12:11 +0200
Message-ID: <4CBF14DB.5020109@redhat.com>
References: <1287590177-25094-1-git-send-email-andi@firstfloor.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: mtosatti@redhat.com, kvm@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
To: Andi Kleen <andi@firstfloor.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:17930 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751459Ab0JTQMT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 20 Oct 2010 12:12:19 -0400
In-Reply-To: <1287590177-25094-1-git-send-email-andi@firstfloor.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

  On 10/20/2010 05:56 PM, Andi Kleen wrote:
> From: Andi Kleen<ak@linux.intel.com>
>
> gcc 4.5 with some special options is able to duplicate the VMX
> context switch asm in vmx_vcpu_run(). This results in a compile error
> because the inline asm sequence uses an on local label. The non local
> label is needed because other code wants to set up the return address.
>

Curious, any idea why gcc does that?  I guess it's the unlikely() near 
the top.

Anyway, patch looks fine.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.