Re: [PATCH 08/10] MCE: Relay UCR MCE to guest

Paolo Bonzini
2010-10-20T21:57:03Z

On 10/20/2010 09:51 PM, Anthony Liguori wrote:
> I don't understand why this loop is needed but we specifically wait for
> a signal to get delivered that's either SIG_IPI or SIGBUS. We then check
> whether a SIG_IPI or SIGBUS is pending and loop waiting for signals again.
>
> Shouldn't we be looping on just sigismember(SIGBUS)?

You mean because SIG_IPI is a real-time signal and standard signals are
delivered first? OTOH, real-time signals can be queued multiple times
so it makes sense to loop on SIG_IPI as well.

> BTW, we're no longer respecting timeout because we're not adjusting ts
> after each iteration.

The timeout of qemu_kvm_eat_signal is always zero.

Paolo