From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, takuya.yoshikawa@gmail.com
Subject: Re: [PATCH RFC] KVM: use kmalloc() for small dirty bitmaps
Date: Thu, 21 Oct 2010 10:38:30 +0200 [thread overview]
Message-ID: <4CBFFC06.5070809@redhat.com> (raw)
In-Reply-To: <4CBF9CAF.4010305@oss.ntt.co.jp>
On 10/21/2010 03:51 AM, Takuya Yoshikawa wrote:
> (2010/10/20 18:34), Takuya Yoshikawa wrote:
>> ** NOT TESTED WELL YET **
>>
>> Currently, we are using vmalloc() for all dirty bitmaps even though
>> they are small enough, say 256 bytes or less.
>>
>> So we use kmalloc() if dirty bitmap size is less than or equal to
>> PAGE_SIZE.
>
>
> Ah, I forgot about the plan to do double buffering.
>
> Making the size of bitmap twice may reduce the benefit of this patch.
Well, 4K single buffer is 128MB worth of RAM. This won't help live
migration much, but will help vga dirty logging, which is active at all
times and uses much smaller memory slots. So I think it's worthwhile.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-10-21 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 9:34 [PATCH RFC] KVM: use kmalloc() for small dirty bitmaps Takuya Yoshikawa
2010-10-21 1:51 ` Takuya Yoshikawa
2010-10-21 8:38 ` Avi Kivity [this message]
2010-10-21 8:45 ` Takuya Yoshikawa
2010-10-21 9:04 ` Avi Kivity
2010-10-21 9:09 ` Takuya Yoshikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBFFC06.5070809@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox