From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC] KVM: use kmalloc() for small dirty bitmaps Date: Thu, 21 Oct 2010 11:04:36 +0200 Message-ID: <4CC00224.7070007@redhat.com> References: <20101020183401.b8241b73.yoshikawa.takuya@oss.ntt.co.jp> <4CBF9CAF.4010305@oss.ntt.co.jp> <4CBFFC06.5070809@redhat.com> <4CBFFDC1.3020803@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, takuya.yoshikawa@gmail.com To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29851 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754188Ab0JUJEn (ORCPT ); Thu, 21 Oct 2010 05:04:43 -0400 In-Reply-To: <4CBFFDC1.3020803@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 10/21/2010 10:45 AM, Takuya Yoshikawa wrote: >> Well, 4K single buffer is 128MB worth of RAM. This won't help live >> migration much, but will help vga dirty logging, which is active at >> all times and uses much smaller memory slots. So I think it's >> worthwhile. >> > > > > Thanks, the patch I sent now should might be better. > > Which one do you prefer? Well, the two combined :) Let's apply the double-buffer first and follow with kmalloc() conversion. -- error compiling committee.c: too many arguments to function