From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takuya Yoshikawa Subject: Re: [PATCH RFC] KVM: use kmalloc() for small dirty bitmaps Date: Thu, 21 Oct 2010 18:09:04 +0900 Message-ID: <4CC00330.5080006@oss.ntt.co.jp> References: <20101020183401.b8241b73.yoshikawa.takuya@oss.ntt.co.jp> <4CBF9CAF.4010305@oss.ntt.co.jp> <4CBFFC06.5070809@redhat.com> <4CBFFDC1.3020803@oss.ntt.co.jp> <4CC00224.7070007@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, takuya.yoshikawa@gmail.com To: Avi Kivity Return-path: Received: from serv2.oss.ntt.co.jp ([222.151.198.100]:38859 "EHLO serv2.oss.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755428Ab0JUJHK (ORCPT ); Thu, 21 Oct 2010 05:07:10 -0400 In-Reply-To: <4CC00224.7070007@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: (2010/10/21 18:04), Avi Kivity wrote: > On 10/21/2010 10:45 AM, Takuya Yoshikawa wrote: >>> Well, 4K single buffer is 128MB worth of RAM. This won't help live migration much, but will help vga dirty logging, which is active at all times and uses much smaller memory slots. So I think it's worthwhile. >>> >> >> >> >> Thanks, the patch I sent now should might be better. >> >> Which one do you prefer? > > Well, the two combined :) > > Let's apply the double-buffer first and follow with kmalloc() conversion. > OK, thanks :) I'll send the kmalloc() patch later! Takuya