From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [SeaBIOS] [PATCH] mark irq9 active high in DSDT Date: Thu, 21 Oct 2010 12:07:17 +0200 Message-ID: <4CC010D5.7070103@redhat.com> References: <20101020093441.GP10207@redhat.com> <20101021020020.GA21095@morn.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , seabios@seabios.org, Anthony Liguori , qemu-devel , KVM list , "Justin M. Forbes" To: "Kevin O'Connor" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:18423 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753596Ab0JUKHn (ORCPT ); Thu, 21 Oct 2010 06:07:43 -0400 In-Reply-To: <20101021020020.GA21095@morn.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 10/21/2010 04:00 AM, Kevin O'Connor wrote: > On Wed, Oct 20, 2010 at 11:34:41AM +0200, Gleb Natapov wrote: > > In PIIX4 SCI (irq9) is active high. Seabios marks it so in interrupt > > override table, but some OSes (FreeBSD) require the same information to > > be present in DSDT too. Make it so. > > > > Signed-off-by: Gleb Natapov > > Thanks. How do we manage the stable series wrt this issue? qemu-kvm-0.12.5 has a regression within the stable series that this patch fixes. qemu 0.12.5 does not, but only because it does not emulate polarity in the I/O APIC correctly. There are several paths we could take: - do nothing, bug is fixed in mainline - release a seabios 0.x.1 for qemu 0.13.1 with this patch - same, plus seabios 0.y.1 for qemu 0.12.6 with this patch - skip qemu (which is not truly affected), patch qemu-kvm's copy of seabios for both 0.12.z and 0.13.z The third option is the most "correct" from a release engineering point of view, but involves more work for everyone. The fourth is quick pain relief but is a little forky. -- error compiling committee.c: too many arguments to function