From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] Type-safe ioport callbacks Date: Mon, 25 Oct 2010 14:56:32 +0200 Message-ID: <4CC57E80.10001@redhat.com> References: <1287934469-16624-1-git-send-email-avi@redhat.com> <1287934469-16624-2-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Juan Quintela Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45819 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755263Ab0JYM4h (ORCPT ); Mon, 25 Oct 2010 08:56:37 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 10/25/2010 02:54 PM, Juan Quintela wrote: > Avi Kivity wrote: > > > +static void ioport_writeb_thunk(void *opaque, uint32_t addr, uint32_t data) > > +{ > > + IOPort *ioport = opaque; > > + > > + return ioport->ops->writeb(ioport, addr, data); > > +} > > + > > +static void ioport_writew_thunk(void *opaque, uint32_t addr, uint32_t data) > > +{ > > + IOPort *ioport = opaque; > > + > > + return ioport->ops->writew(ioport, addr, data); > > +} > > + > > +static void ioport_writel_thunk(void *opaque, uint32_t addr, uint32_t data) > > +{ > > + IOPort *ioport = opaque; > > + > > + return ioport->ops->writel(ioport, addr, data); > > +} > > "return" is not needed on this three functions. > Fixed. -- error compiling committee.c: too many arguments to function