From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks Date: Mon, 25 Oct 2010 08:46:48 -0500 Message-ID: <4CC58A48.6070204@codemonkey.ws> References: <1287934469-16624-1-git-send-email-avi@redhat.com> <4CC46E73.2090704@redhat.com> <4CC46F22.7070202@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Paolo Bonzini , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:54069 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755764Ab0JYNqu (ORCPT ); Mon, 25 Oct 2010 09:46:50 -0400 Received: by qwk3 with SMTP id 3so1380679qwk.19 for ; Mon, 25 Oct 2010 06:46:50 -0700 (PDT) In-Reply-To: <4CC46F22.7070202@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/24/2010 12:38 PM, Avi Kivity wrote: > On 10/24/2010 07:35 PM, Paolo Bonzini wrote: >> On 10/24/2010 05:34 PM, Avi Kivity wrote: >>> A recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler >>> complaining because of the type-unsafeness of the ioport callbacks. >>> This >>> patchset adds a type-safe variant of ioport callbacks and coverts a >>> sample >>> ioport. Converting the other 300-odd registrations is left as an >>> excercise >>> to the community. >> >> Should we create a Documentation/ file with incomplete transitions >> and the commit(s) that introduced them, for volunteers who wish to do >> some dirty work or to learn Coccinelle? > > If we have a TODO, we could add a janitor section there. That's unnecessary work. The vast majority of the callers of register_ioport* should be using a bus specific interface instead. Regards, Anthony Liguori